This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
8/8 master -> stable #135
Merged
8/8 master -> stable #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for empty if, similar to bind and repeat.
john points out that it's weird for TemplateBinding.node to point to the template iterator. We don't really have a clear delineation of public vs private API right now, but I agree that the iterator reference should really be private. I'm not prepared yet to go through and start marking private members with trailing underscores. We had that for a while and it just go really ugly. Hopefully, once we get all of our semantics nailed down, we can write the spec and the IDL and that will make it clear. r=arv BUG= Review URL: https://codereview.appspot.com/12296043
I think if we spec'd Node.bind, path would be optional and default to '' (in WebIDL). I realize this impl is kind of cheating, but I think it's the best current option. R=arv BUG= Review URL: https://codereview.appspot.com/12299043
R=arv BUG= Review URL: https://codereview.appspot.com/12573043
R=arv Review URL: https://codereview.appspot.com/12574043
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.