Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Stores value as numeric for number input types #19

Merged
merged 3 commits into from
Feb 4, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/NodeBind.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@
var eventType = getEventForInputType(input);

function eventHandler() {
observable.setValue(input[property]);
var isNum = property == 'value' && input.type == 'number';
observable.setValue(isNum ? input.valueAsNumber : input[property]);
observable.discardChanges();
(postEventFn || noop)(input);
Platform.performMicrotaskCheckpoint();
Expand Down
16 changes: 16 additions & 0 deletions tests/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,22 @@ suite('Form Element Bindings', function() {
radioInputCheckedMultipleForms(shadowRoot, done);
});

test('(Number)Input.value', function(done) {
var input = testDiv.appendChild(document.createElement('input'));
testDiv.appendChild(input);
input.type = 'number';
var model = {x: 0};
bindings.push(input.bind('value', new PathObserver(model, 'x')));
input.value = "999";

then(function() {
dispatchEvent('input', input);
assert.isNumber(model.x);
assert.strictEqual(999, model.x);
done();
});
});

test('Select.selectedIndex', function(done) {
var select = testDiv.appendChild(document.createElement('select'));
testDiv.appendChild(select);
Expand Down