This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Stores value as numeric for number input types #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added numeric test
| observable.setValue(input[property]); | ||
| if (property == 'value' && input.type == 'number' ) | ||
| observable.setValue(input.valueAsNumber); | ||
| else |
There was a problem hiding this comment.
trivial: I don't think the JS style in this file uses dangling else. I'd suggest curlies for the if-else, or maybe restructure:
var isNum = property == 'value' && input.type == 'number';
observable.setValue(isNum ? input.valueAsNumber : input[property]);the JS style guide endorses ternary op for what it's worth: https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Tips_and_Tricks#Tips_and_Tricks
|
a couple of very minor comments, otherwise LGTM :) |
|
(and thank you for putting together the pull request!) |
|
@jmesserly thanks, I've responded to your feedback. |
|
awesome, thanks again |
jmesserly
pushed a commit
that referenced
this pull request
Feb 4, 2015
Stores value as numeric for number input types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added numeric test
closes #18