feat!: support multiple commits in footer #686
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 85.04% 85.15% +0.10%
==========================================
Files 48 48
Lines 5838 5894 +56
Branches 542 520 -22
==========================================
+ Hits 4965 5019 +54
- Misses 872 874 +2
Partials 1 1
Continue to review full report at Codecov.
|
| (node: FooterNodes) => { | ||
| switch (node.type) { | ||
| case 'scope': | ||
| footerText += `(${node.value})`; |
There was a problem hiding this comment.
This is necessary because we don't currently include ( and ) in the parser, I'd like to add a parenthesis node, which would simplify logic.
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Is the meta: header required to parse the extra commit messages?
If not, I could see inadvertent messages being parsed from a multiple commit squash and merge from the GitHub UI.
src/conventional-commits.ts
Outdated
| text: string; | ||
| } | ||
|
|
||
| function getParsedCommits(commits: Commit[]) { |
There was a problem hiding this comment.
Can you add the return type?
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Please update the README to describe what you can do with this feature.
🤖 I have created a release \*beep\* \*boop\* --- ## [9.0.0](https://www.github.com/googleapis/release-please/compare/v8.2.0...v9.0.0) (2021-01-08) ### ⚠ BREAKING CHANGES * support multiple commits in footer (#686) ### Features * support multiple commits in footer ([#686](https://www.github.com/googleapis/release-please/issues/686)) ([b3f96d8](https://www.github.com/googleapis/release-please/commit/b3f96d8dd988b7d482223e8a7868a45043db4880)) ### Bug Fixes * `findFilesByfilename` respects `path` option ([#665](https://www.github.com/googleapis/release-please/issues/665)) ([a3a1df6](https://www.github.com/googleapis/release-please/commit/a3a1df690f48b38c539ee5aab5ae046d640c6811)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
5 participants
BREAKING CHANGE: footers that look like commits will now be displayed in the CHANGELOG.
This PR adds support for expanding multiple commits, represented by a single commit message, into multiple commits in the CHANGELOG.
It expects the format:
Where:
meta: multiple commits, can be anything), there are footers that looks like Conventional Commits.Refs: #667
Fixes: #614
CC: @miraleung