Skip to content

Conversation

@rollyjoel
Copy link
Contributor

scope code search to path and return paths relative to path.
update python releaser to call findFilesByfilename appropriately.

Fixes #664

@rollyjoel rollyjoel requested a review from a team as a code owner December 10, 2020 23:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #665 (530265b) into master (5735410) will decrease coverage by 0.00%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   85.05%   85.04%   -0.01%     
==========================================
  Files          48       48              
  Lines        5821     5838      +17     
  Branches      539      542       +3     
==========================================
+ Hits         4951     4965      +14     
- Misses        869      872       +3     
  Partials        1        1              
Impacted Files Coverage Δ
src/releasers/python.ts 34.96% <0.00%> (-0.75%) ⬇️
src/github.ts 83.23% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5735410...530265b. Read the comment docs.

@rollyjoel
Copy link
Contributor Author

rollyjoel commented Dec 10, 2020

I wasn't quite up to adding a test/releasers/python.ts so codecov nailed me :-( I'd be happy to augment a test file if someone else starts it. I looked briefly at test/releasers/node.ts and decided I didn't have the time to invest in figuring it out/porting it for the python releaser, at least not before getting buy-in on this solution.

@bcoe
Copy link

bcoe commented Dec 15, 2020

@joeldodge79 I'm on a vacation for the next few days, very much appreciate the patch, will look soon.

@bcoe
Copy link

bcoe commented Dec 21, 2020

@joeldodge79 this looks like a good fix to me 👍

scope code search to `path` and return paths relative to `path`.
update python releaser to call `findFilesByfilename` appropriately.
@rollyjoel rollyjoel force-pushed the joeldodge/python-version-path-fix branch 2 times, most recently from 356bbe6 to 3fea008 Compare January 5, 2021 14:38
@rollyjoel
Copy link
Contributor Author

@bcoe sorry for the lag, I was completely unplugged for the past two weeks. I just rebased the branch. There's still the codecov issue for test/releasers/python.ts ... ok to let slide for now?

@bcoe bcoe merged commit a3a1df6 into googleapis:master Jan 8, 2021
@rollyjoel rollyjoel deleted the joeldodge/python-version-path-fix branch February 9, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python releaser not finding version.py with path option

2 participants