Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat!: drop node8 support, support for async iterators #335

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

alexander-fenster
Copy link
Contributor

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #335 into master will increase coverage by 9.83%.
The diff coverage is 98.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage    88.3%   98.13%   +9.83%     
==========================================
  Files           3        3              
  Lines        2342     2740     +398     
  Branches       79       99      +20     
==========================================
+ Hits         2068     2689     +621     
+ Misses        273       50     -223     
  Partials        1        1
Impacted Files Coverage Δ
src/v1/data_transfer_service_client.ts 98.1% <98.91%> (+10.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3519a55...026f2b9. Read the comment docs.

@xiaozhenliu-gg5 xiaozhenliu-gg5 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 31, 2020
@AVaksman
Copy link

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 31, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit e9a9b24 into master Mar 31, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 10, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/compare/v1.5.3...v2.0.0) (2020-04-10)


### ⚠ BREAKING CHANGES

* The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
* move API to typescript code generation (#300)

### Features

* bump release level to GA ([#296](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/296)) ([8d1850a](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/8d1850ad542efb7d6f5ceac245f6e69c6f0550ed))
* deferred client initialization ([#321](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/321)) ([dc667b3](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/dc667b31d22796946bf94a01ece0cb60d083049c))
* drop node8 support, support for async iterators ([#335](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/335)) ([e9a9b24](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/e9a9b240159d9dd8e22e99bc733b5ff6a023b769))
* export protos in src/index.ts ([7426c53](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/7426c53e19b040c60b2c12267eb494b5db90b32a))
* move API to typescript code generation ([#300](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/300)) ([9094a74](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/9094a74364a8b1a19dff53926453d4a777d5fb21))
* use first party client oauth ([b687434](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/b687434b6f11e8f3539cc07b7bd8c8234211286a))


### Bug Fixes

* export explicit version from protos.js ([#339](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/issues/339)) ([5ed9ed0](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/5ed9ed0117e697711098602a0c7270faa99eb9d5))
* pass x-goog-request-params header for streaming calls ([1af9266](https://www.github.com/googleapis/nodejs-bigquery-data-transfer/commit/1af926661ef293b920849562a9106799b212d793))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants