Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Commit

Permalink
feat!: drop node8 support, support for async iterators (#335)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
  • Loading branch information
alexander-fenster authored Mar 31, 2020
1 parent 3519a55 commit e9a9b24
Show file tree
Hide file tree
Showing 14 changed files with 4,075 additions and 1,383 deletions.
3 changes: 3 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "./node_modules/gts"
}
15 changes: 0 additions & 15 deletions .eslintrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [8, 10, 12, 13]
node: [10, 12, 13]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
8 changes: 0 additions & 8 deletions .prettierrc

This file was deleted.

17 changes: 17 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

module.exports = {
...require('gts/.prettierrc.json')
}
10 changes: 6 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc",
"engines": {
"node": ">=8.10.0"
"node": ">=10"
},
"repository": "googleapis/nodejs-bigquery-data-transfer",
"main": "build/src/index.js",
Expand Down Expand Up @@ -42,17 +42,18 @@
"prelint": "cd samples; npm link ../; npm i"
},
"dependencies": {
"google-gax": "^1.9.0"
"google-gax": "^2.0.1"
},
"devDependencies": {
"@types/mocha": "^5.2.5",
"@types/node": "^12.0.0",
"@types/sinon": "^7.5.2",
"c8": "^7.0.0",
"eslint": "^6.0.0",
"eslint-config-prettier": "^6.0.0",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-prettier": "^3.1.0",
"gts": "^1.0.0",
"gts": "2.0.0-alpha.9",
"jsdoc": "^3.6.2",
"jsdoc-fresh": "^1.0.1",
"jsdoc-region-tag": "^1.0.2",
Expand All @@ -61,8 +62,9 @@
"null-loader": "^3.0.0",
"pack-n-play": "^1.0.0-2",
"prettier": "^1.11.1",
"sinon": "^9.0.1",
"ts-loader": "^6.2.1",
"typescript": "^3.7.0",
"typescript": "^3.8.3",
"webpack": "^4.41.2",
"webpack-cli": "^3.3.10"
}
Expand Down
108 changes: 54 additions & 54 deletions protos/protos.d.ts

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions smoke-test/data_transfer_service_smoke_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe('DataTransferServiceSmokeTest', () => {
const projectId = process.env.GCLOUD_PROJECT;

it('successfully makes a call to the service using promises', done => {
// eslint-disable-next-line node/no-missing-require
const bigqueryDataTransfer = require('../src');

const client = new bigqueryDataTransfer.v1.DataTransferServiceClient({
Expand All @@ -45,6 +46,7 @@ describe('DataTransferServiceSmokeTest', () => {
});

it('successfully makes a call to the service using callbacks', done => {
// eslint-disable-next-line node/no-missing-require
const bigqueryDataTransfer = require('../src');

const client = new bigqueryDataTransfer.v1.DataTransferServiceClient({
Expand Down Expand Up @@ -78,6 +80,7 @@ describe('DataTransferServiceSmokeTest', () => {
});

it('successfully makes a call to the service using streaming', done => {
// eslint-disable-next-line node/no-missing-require
const bigqueryDataTransfer = require('../src');

const client = new bigqueryDataTransfer.v1.DataTransferServiceClient({
Expand Down
Loading

0 comments on commit e9a9b24

Please sign in to comment.