ci(cloudhealthcare, dataproc, postgres): fix multiple integration test failures#2602
ci(cloudhealthcare, dataproc, postgres): fix multiple integration test failures#2602duwenxin99 merged 7 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issues in the Cloud Healthcare integration tests by correcting how DICOM store paths and IDs are passed to test functions. It also introduces a new utility to programmatically upload dummy DICOM data, ensuring that DICOM store-related tests have the necessary data to run successfully. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix integration tests for Cloud Healthcare. The changes include correcting the store ID used for DICOM metrics tests, making list assertions more robust, and adding data population for DICOM stores during test setup.
My review has identified a few areas for improvement:
- The newly populated DICOM data is not being used by the search-related tests, which still point to a pre-populated store. This seems to be an incomplete fix.
- There's an inconsistency in how list operations are tested for FHIR and DICOM stores.
- There's a minor error handling issue in the new
uploadDummyDICOMhelper function.
I've added specific comments with suggestions for each of these points.
|
/gcbrun |
duwenxin99
changed the title
Make sure all empty results are initialized array instead of nil array to fix: ` dataproc_integration_test.go:431: unexpected clusters: got [], want [] ` Test log: https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/48a4c6fc-d5c5-4eba-8184-b8e21954f62f;step=45?e=13802955&mods=logs_tg_staging&project=toolbox-testing-438616
Add schema cleanup routine based on timestamp at the beginning of the test. Add timestamp to schema name.
duwenxin99
changed the title
…is#2602) - Make the DICOM stores test self-contained and not using prepopulated test data - Make sure the responses from list DICOM tool are status OK but do not check for specific result due to pagination not supported. The list result is limited to the first 100 items, so the wanted entry is not guaranteed to be in the returned result.
3 participants
Uh oh!
There was an error while loading. Please reload this page.