Skip to content

ci(postgres): fix postgres list stored procedure flaky test#2605

Merged
duwenxin99 merged 4 commits intofix-healthcarefrom
postgres
Mar 2, 2026
Merged

ci(postgres): fix postgres list stored procedure flaky test#2605
duwenxin99 merged 4 commits intofix-healthcarefrom
postgres

Conversation

@duwenxin99
Copy link
Copy Markdown
Contributor

@duwenxin99 duwenxin99 commented Mar 2, 2026

Add schema cleanup routine based on timestamp at the beginning of the test. Add timestamp to schema name.

@duwenxin99 duwenxin99 requested a review from a team as a code owner March 2, 2026 20:52
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a flaky test related to listing PostgreSQL stored procedures. It improves test reliability by initializing a Go slice to an empty state to prevent nil dereferences and by relaxing a specific count assertion in a test case that was contributing to its instability.

Highlights

  • Defensive Programming: The clusterPbs slice in internal/sources/dataproc/dataproc.go was explicitly initialized to an empty slice []*dataprocpb.Cluster{} to prevent potential nil pointer issues and ensure consistent behavior.
  • Test Stability: The expectedCount assertion was removed from a test case in tests/tool.go for listing stored procedures, addressing flakiness by focusing on the presence of data rather than an exact count.
Changelog
  • internal/sources/dataproc/dataproc.go
    • Initialized clusterPbs slice to an empty slice.
  • tests/tool.go
    • Removed expectedCount assertion from a test case.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@duwenxin99 duwenxin99 changed the base branch from main to fix-dataproc March 2, 2026 20:52
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The original code review comment regarding test flakiness and assertion strength in RunPostgresListStoredProcedureTest has been retained as it does not contradict any of the provided rules and offers valuable feedback for improving test robustness.

Comment thread tests/tool.go
@duwenxin99 duwenxin99 force-pushed the postgres branch 3 times, most recently from da01ffc to 3a7e38a Compare March 2, 2026 21:20
Base automatically changed from fix-dataproc to fix-healthcare March 2, 2026 21:29
@duwenxin99 duwenxin99 merged commit fe4a461 into fix-healthcare Mar 2, 2026
13 of 14 checks passed
@duwenxin99 duwenxin99 deleted the postgres branch March 2, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants