fix: adapt to introduction of java.time in gax #3200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
added
the
do not merge
product-auto-label
bot
added
size: s
diegomarquezp
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jul 8, 2024
…all (#3016) Fixes #3015 Fixes #3014 Gax tracing internally works with `attemptFailedDuration`, which defaults to a no-op. Downstream libraries use `attemptFailed`, which has a custom behavior. What happens when an attempt-failed event occurs is that `attemptFailedDuration` is called instead (in favor of using java.time methods internally). This fix makes `attemptFailedDuration`'s behavior to delegate the logic to `attemptFailed`. The downstreams will keep failing because the repos haven't got adapted to the new change in gax. See the follow ups below. ### Fixes in `java-spanner`  ### Fixes in `java-bigtable`  ### Follow ups in `java-bigtable` More failures in java-bigtable to be addressed in that repo: ``` Error: BigtableTableAdminSettingsTest.testToString:175 expected to contain: totalTimeout=PT13H32M but was : BigtableTableAdminSettings{projectId=our-project-85, instanceId=our-instance-06, ... ``` Fixed in googleapis/java-bigtable#2274 ### Follow ups in `java-spanner` ``` Error: Failures: Error: CompositeTracerTest.testMethodsOverrideMetricsTracer:238 Method not found in compositeTracerMethods: public void com.google.api.gax.tracing.MetricsTracer.attemptFailedDuration(java.lang.Throwable,java.time.Duration) ``` Fixed in googleapis/java-spanner#3200
This was referenced Jul 9, 2024
lqiu96
force-pushed
the
fix-javatime-updates
branch
from
7091d34
to
abc3766
Compare
lqiu96
removed
the
do not merge
lqiu96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Closing as this seems to have been fixed in #3243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after
gapic-generator-java >2.24.0is merged.This adapts
CompositeTracerto also includeattemptFailedDuration, which was recently introduced in googleapis/sdk-platform-java#1872Confirmed it works by using
gax 2.51.1-SNAPSHOT