New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The java-spanner downstream check started failing since #1872 #3014

Closed

diegomarquezp opened this issue Jul 4, 2024 · 0 comments · Fixed by #3016

Contributor

diegomarquezp commented Jul 4, 2024 •

edited

Loading

The java-spanner downstream check is failing because a new method attemptFailedDuration was added to BaseApiTracer.

Error:  Failures: 
Error:    CompositeTracerTest.testMethodsOverrideMetricsTracer:238 Method not found in compositeTracerMethods: public void com.google.api.gax.tracing.MetricsTracer.attemptFailedDuration(java.lang.Throwable,java.time.Duration)

The test CompositeTracerTest.testMethodsOverrideMetricsTracer verifies that the class CompositeTracer has an overridden declaration of each method of BaseApiTracer, which is not true as of July 4th.

The text was updated successfully, but these errors were encountered:

diegomarquezp mentioned this issue

fix: BaseApiTracer to noop on attemptFailed via overloaded method call #3016

Merged

diegomarquezp closed this as completed in #3016

diegomarquezp closed this as completed in

2fc938a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment