Skip to content

chore: remove tag restrictions in Connection API #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olavloite merged 1 commit into from
Mar 26, 2024
Merged

chore: remove tag restrictions in Connection API #2970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...-spanner/src/main/resources/com/google/cloud/spanner/connection/ClientSideStatements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,11 +449,11 @@
"statementType": "SET_STATEMENT_TAG",
"regex": "(?is)\\A\\s*set\\s+statement_tag\\s*(?:=)\\s*(.*)\\z",
"method": "statementSetStatementTag",
"exampleStatements": ["set statement_tag='tag1'", "set statement_tag='tag2'", "set statement_tag=''"],
"exampleStatements": ["set statement_tag='tag1'", "set statement_tag='tag2'", "set statement_tag=''", "set statement_tag='test_tag'"],
"setStatement": {
"propertyName": "STATEMENT_TAG",
"separator": "=",
"allowedValues": "'(([a-zA-Z][a-zA-Z0-9_\\-]{1,63})|())'",
"allowedValues": "'(.*)'",
"converterName": "ClientSideStatementValueConverters$StringValueConverter"
}
},
Expand All @@ -464,12 +464,12 @@
"statementType": "SET_TRANSACTION_TAG",
"regex": "(?is)\\A\\s*set\\s+transaction_tag\\s*(?:=)\\s*(.*)\\z",
"method": "statementSetTransactionTag",
"exampleStatements": ["set transaction_tag='tag1'", "set transaction_tag='tag2'", "set transaction_tag=''"],
"exampleStatements": ["set transaction_tag='tag1'", "set transaction_tag='tag2'", "set transaction_tag=''", "set transaction_tag='test_tag'"],
"examplePrerequisiteStatements": ["set autocommit = false"],
"setStatement": {
"propertyName": "TRANSACTION_TAG",
"separator": "=",
"allowedValues": "'(([a-zA-Z][a-zA-Z0-9_\\-]{1,63})|())'",
"allowedValues": "'(.*)'",
"converterName": "ClientSideStatementValueConverters$StringValueConverter"
}
},
Expand Down
10 changes: 6 additions & 4 deletions ...anner/src/main/resources/com/google/cloud/spanner/connection/PG_ClientSideStatements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,12 +621,13 @@
"set spanner.statement_tag=''",
"set spanner.statement_tag to 'tag1'",
"set spanner.statement_tag to 'tag2'",
"set spanner.statement_tag to ''"
"set spanner.statement_tag to ''",
"set spanner.statement_tag to 'test_tag'"
],
"setStatement": {
"propertyName": "SPANNER.STATEMENT_TAG",
"separator": "(?:=|\\s+TO\\s+)",
"allowedValues": "'(([a-zA-Z][a-zA-Z0-9_\\-]{1,63})|())'",
"allowedValues": "'(.*)'",
"converterName": "ClientSideStatementValueConverters$StringValueConverter"
}
},
Expand All @@ -643,13 +644,14 @@
"set spanner.transaction_tag=''",
"set spanner.transaction_tag to 'tag1'",
"set spanner.transaction_tag to 'tag2'",
"set spanner.transaction_tag to ''"
"set spanner.transaction_tag to ''",
"set spanner.transaction_tag to 'test_tag'"
],
"examplePrerequisiteStatements": ["set autocommit = false"],
"setStatement": {
"propertyName": "SPANNER.TRANSACTION_TAG",
"separator": "(?:=|\\s+TO\\s+)",
"allowedValues": "'(([a-zA-Z][a-zA-Z0-9_\\-]{1,63})|())'",
"allowedValues": "'(.*)'",
"converterName": "ClientSideStatementValueConverters$StringValueConverter"
}
},
Expand Down
Loading