chore: remove tag restrictions in Connection API #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Connection API used a regex to limit the possible values that could be set for statement and transaction tags. These limitations were not in sync with what the actual allowed values for tags are in Spanner. The restrictions in the Connection API have therefore been removed, and all validation is done by the Spanner backend instead.
product-auto-label
bot
added
size: xl
pratickchokhani
approved these changes
Mar 26, 2024
arpan14
pushed a commit
to arpan14/java-spanner
that referenced
this pull request
Apr 1, 2024
The Connection API used a regex to limit the possible values that could be set for statement and transaction tags. These limitations were not in sync with what the actual allowed values for tags are in Spanner. The restrictions in the Connection API have therefore been removed, and all validation is done by the Spanner backend instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Connection API used a regex to limit the possible values that could be set for statement and transaction tags. These limitations were not in sync with what the actual allowed values for tags are in Spanner. The restrictions in the Connection API have therefore been removed, and all validation is done by the Spanner backend instead.