chore: derive shared-dependencies version from effective pom #6531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ModelBuilder builder = new DefaultModelBuilderFactory().newInstance(); | ||
| Model effectiveModel = builder.build(request).getEffectiveModel(); | ||
| return effectiveModel.getProperties().getProperty("google-cloud-shared-dependencies.version"); | ||
| } catch (XmlPullParserException | IOException ignored) { |
Member
There was a problem hiding this comment.
Do we know why these exceptions are ignored, but the ModelBuildingException is thrown?
Contributor
Author
There was a problem hiding this comment.
That is a good question. It is a little unclear as to why the exceptions were ignored. https://effectivejava.googleplex.com/third-edition#page=331 advices against this especially without appropriate comments explaining the reasoning and suggests the following to avoid silent failures:
Merely letting an exception propagate outward can at least cause the
program to fail swiftly, preserving information to aid in debugging the failure.
suztomo
approved these changes
Apr 22, 2024
...ard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/ArtifactMavenData.java
Outdated
Show resolved
Hide resolved
burkedavison
approved these changes
Apr 23, 2024
…dbomdashboard/ArtifactMavenData.java Co-authored-by: Burke Davison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6523. Locally tested by calling: