Investigate shared-dependencies-convergence failure

[mpeddada1]

The check has been failing since #6487 with:

java.lang.RuntimeException: Failed to converge dependencies
    at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.main (DashboardMain.java:114)
    at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:254)
    at java.lang.Thread.run (Thread.java:750)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:03 min
[INFO] Finished at: 2024-04-03T15:40:15Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java (default-cli) on project google-cloud-bom-dashboard: An exception occured while executing the Java class. Failed to converge dependencies -> [Help 1]

[Desired Outcome] Locally running DashboardMain on the `26.24.0/ passes with:

Shared dependencies converge \o/
Disconnected from the target VM, address: '127.0.0.1:46233', transport: 'socket'

Process finished with exit code 0

[suztomo]

Memo. It used to print the cause of errors. Somehow the message in standard error output was discarded in GitHub Actions.

[mpeddada1]

Debugging Observations:

The shared-dependencies versions end up being empty, which results in sharedDepsVersions.size() being 0.

java-cloud-bom/dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/DashboardMain.java

Line 218 in 1eb8167

if (sharedDepsVersions.size() == 1) {

How does DashboardMain read the shared-dependencies version?
Ans. It reads it from the pom.xml of the artifacts. This line looks for the google-cloud-shared-dependencies artifact in the dependencyManagement section:

java-cloud-bom/dashboard/src/main/java/com/google/cloud/tools/opensource/cloudbomdashboard/ArtifactMavenData.java

Line 228 in 721ee55

&& "google-cloud-shared-dependencies".equals(dep.getArtifactId())) {

The poms in the client libraries were recently changed to use a placeholder for the shared-dependencies version and rely on sdk-platform-java-config to provide the value. (example)

Potential Solutions:

1. Look for sdk-platform-java-config in ArtifactMavenData to get the desired shared-dependencies version.
2. (Not verified) Perhaps add logic to get effective-pom data and grab the shared-dependencies version from there?

[suztomo]

Thank you for solving the mystery. The list was empty. Thus no error message.

Memo: Example change that changed the value of the shared dependencies BOM from a concrete value to a variable: googleapis/java-bigtable@1518017#diff-40e11eb145927bc1de9f1545cdf1d74332b85c2614d26b186121346342053dad

[suztomo]

On "get effective-pom data", here is the effective-pom of java-pubsublite: https://gist.github.com/suztomo/88c21e4f85a256f747cc1c8275417284. An interesting value is at the properties section:

  <properties>
    <auto-value.version>1.10.4</auto-value.version>
    <docRoot>/java/docs/reference/</docRoot>
    <google-cloud-shared-dependencies.version>3.28.1</google-cloud-shared-dependencies.version>