Skip to content

ci: allow nonexistent profile in google-cloud-bigtable #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

ci: allow nonexistent profile in google-cloud-bigtable #2611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce6f467
ci: allow nonexistent profile in google-cloud-bigtable
suztomo Jun 23, 2025
4efc30b
chore: generate libraries at Mon Jun 23 01:34:13 UTC 2025
cloud-java-bot Jun 23, 2025
081a508
wrap the enforcer rule with a profile that is activated by default
suztomo Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 63 additions & 48 deletions google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,69 @@
</dependencies>

<profiles>
<profile>
<id>enable-enforcer-rules</id>
<activation>
<property>
<!-- By default, Maven runs the enforcer rules. The shared release script
may pass profile name that doesn't exist in this project. Let's ignore
the enforcer rule (requireProfileIdsExist) in that case, leveraging
the presence of the performRelease property. -->
<name>!performRelease</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.5.0</version>
<executions>
<!-- Prevent users from mistyping a profile name -->
<execution>
<id>enforce-valid-profile</id>
<configuration>
<rules>
<requireProfileIdsExist/>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
<!-- Ensure that greatest version of each transitive dependency got selected -->
<execution>
<id>enforce-dependency-upper-bound</id>
<configuration>
<rules>
<requireUpperBoundDeps/>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
<!--
workaround for https://github.com/mojohaus/extra-enforcer-rules/issues/132
Remove when it's fixed upstream.
-->
<dependencies>
<dependency>
<groupId>org.codehaus.mojo</groupId>
<artifactId>extra-enforcer-rules</artifactId>
<version>1.8.0</version>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-dependency-tree</artifactId>
<version>3.3.0</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>enable-verbose-grpc-logs</id>
<properties>
Expand Down Expand Up @@ -668,54 +731,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.5.0</version>
<executions>
<!-- Prevent users from mistyping a profile name -->
<execution>
<id>enforce-valid-profile</id>
<configuration>
<rules>
<requireProfileIdsExist/>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
<!-- Ensure that greatest version of each transitive dependency got selected -->
<execution>
<id>enforce-dependency-upper-bound</id>
<configuration>
<rules>
<requireUpperBoundDeps/>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
<!--
workaround for https://github.com/mojohaus/extra-enforcer-rules/issues/132
Remove when it's fixed upstream.
-->
<dependencies>
<dependency>
<groupId>org.codehaus.mojo</groupId>
<artifactId>extra-enforcer-rules</artifactId>
<version>1.8.0</version>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-dependency-tree</artifactId>
<version>3.3.0</version>
</dependency>
</dependencies>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
Expand Down
3 changes: 2 additions & 1 deletion google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ public void testFromProto() {
assertThat(result.isAutomatedBackupEnabled()).isTrue();
assertEquals(
result.getAutomatedBackupPolicy().viewConfig(),
"AutomatedBackupPolicy{com.google.bigtable.admin.v2.Table$AutomatedBackupPolicy.retention_period=seconds: 1\n"
"AutomatedBackupPolicy{com.google.bigtable.admin.v2.Table$AutomatedBackupPolicy.retention_period=seconds:"
+ " 1\n"
+ //
"nanos: 99\n"
+ //
Expand Down
Loading