ci: allow nonexistent profile in google-cloud-bigtable #2611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our release job specifies profiles that may or may not exist in all Java projects in our release pipeline. The requireProfileIdsExist enforcer rule fails in that case. Therefore, let's remove the requireProfileIdsExist rule.
product-auto-label
bot
added
size: s
mpeddada1
previously approved these changes
Jun 23, 2025
Member
Author
|
Somehow the bot added a commit 4efc30b that touches Java code. Now it requires api-bigtable team's review. |
Contributor
|
I'm a little concerned about removing this check. This is to prevent false positives when someone mistyped a profile name. Are there alternatives? |
product-auto-label
bot
added
size: m
Member
Author
|
@mutianf Updated it to use a profile that's activated by default. PTAL. |
mutianf
approved these changes
Jun 23, 2025
mutianf
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
nicholsl
pushed a commit
to nicholsl/java-bigtable
that referenced
this pull request
Jul 16, 2025
Our new release job script specifies profiles that might not exist in all Java projects in our release pipeline. The requireProfileIdsExist enforcer rule fails in that case.
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-valid-profile) on project google-cloud-bigtable:
[ERROR] Rule 0: org.apache.maven.enforcer.rules.RequireProfileIdsExist failed with message:
[ERROR] The requested profile doesn't exist: release-staging-repository
```
Therefore, let's disable the requireProfileIdsExist rule during the release. This change created a profile that does that:
```
<profile>
<id>enable-enforcer-rules</id>
<activation>
<property>
<!-- By default, Maven runs the enforcer rules. The shared release script
may pass profile name that doesn't exist in this project. Let's ignore
the enforcer rule (requireProfileIdsExist) in that case, leveraging
the presence of the performRelease property. -->
<name>!performRelease</name>
</property>
...
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our new release job script specifies profiles that might not exist in all Java projects in our release pipeline. The requireProfileIdsExist enforcer rule fails in that case.
Therefore, let's disable the requireProfileIdsExist rule during the release. This change created a profile that does that: