Skip to content

feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing #5897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haphungw merged 6 commits into from
Jul 10, 2026
Merged

feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing #5897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d054d06
feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing
haphungw Jul 9, 2026
c711054
chore: regenerate clients without outer braces
haphungw Jul 9, 2026
1293f52
chore: update librarian pseudo-version and tests
haphungw Jul 9, 2026
ae2e7c5
chore: add additional generated services
haphungw Jul 9, 2026
5e1a5cf
fix expected rpc.method for lro polling
haphungw Jul 9, 2026
97e22d7
format
haphungw Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
language: rust
version: v0.25.0
version: v0.25.1-0.20260709214352-8266ce39cdfc
repo: googleapis/google-cloud-rust
sources:
conformance:
Expand Down
76 changes: 8 additions & 68 deletions src/generated/api/apikeys/v2/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,7 @@ pub mod api_keys {
type Operation = google_cloud_lro::internal::Operation<crate::model::Key, wkt::Empty>;
let polling_error_policy = self.0.stub.get_polling_error_policy(&self.0.options);
let polling_backoff_policy = self.0.stub.get_polling_backoff_policy(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
let mut poller_options = self.0.stub.get_poller_options(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
if let Some(ref mut details) = poller_options.tracing {
details.method_name =
"google_cloud_apikeys_v2::client::ApiKeys::create_key::until_done";
Expand All @@ -153,21 +151,7 @@ pub mod api_keys {
Ok(Operation::new(op))
};

#[cfg(google_cloud_unstable_tracing)]
{
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
polling_backoff_policy,
start,
query,
)
}
.with_options(poller_options)
}

#[cfg(not(google_cloud_unstable_tracing))]
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
Expand All @@ -176,6 +160,7 @@ pub mod api_keys {
query,
)
}
.with_options(poller_options)
}

/// Sets the value of [parent][crate::model::CreateKeyRequest::parent].
Expand Down Expand Up @@ -503,9 +488,7 @@ pub mod api_keys {
type Operation = google_cloud_lro::internal::Operation<crate::model::Key, wkt::Empty>;
let polling_error_policy = self.0.stub.get_polling_error_policy(&self.0.options);
let polling_backoff_policy = self.0.stub.get_polling_backoff_policy(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
let mut poller_options = self.0.stub.get_poller_options(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
if let Some(ref mut details) = poller_options.tracing {
details.method_name =
"google_cloud_apikeys_v2::client::ApiKeys::update_key::until_done";
Expand All @@ -532,21 +515,7 @@ pub mod api_keys {
Ok(Operation::new(op))
};

#[cfg(google_cloud_unstable_tracing)]
{
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
polling_backoff_policy,
start,
query,
)
}
.with_options(poller_options)
}

#[cfg(not(google_cloud_unstable_tracing))]
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
Expand All @@ -555,6 +524,7 @@ pub mod api_keys {
query,
)
}
.with_options(poller_options)
}

/// Sets the value of [key][crate::model::UpdateKeyRequest::key].
Expand Down Expand Up @@ -660,9 +630,7 @@ pub mod api_keys {
type Operation = google_cloud_lro::internal::Operation<crate::model::Key, wkt::Empty>;
let polling_error_policy = self.0.stub.get_polling_error_policy(&self.0.options);
let polling_backoff_policy = self.0.stub.get_polling_backoff_policy(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
let mut poller_options = self.0.stub.get_poller_options(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
if let Some(ref mut details) = poller_options.tracing {
details.method_name =
"google_cloud_apikeys_v2::client::ApiKeys::delete_key::until_done";
Expand All @@ -689,21 +657,7 @@ pub mod api_keys {
Ok(Operation::new(op))
};

#[cfg(google_cloud_unstable_tracing)]
{
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
polling_backoff_policy,
start,
query,
)
}
.with_options(poller_options)
}

#[cfg(not(google_cloud_unstable_tracing))]
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
Expand All @@ -712,6 +666,7 @@ pub mod api_keys {
query,
)
}
.with_options(poller_options)
}

/// Sets the value of [name][crate::model::DeleteKeyRequest::name].
Expand Down Expand Up @@ -791,9 +746,7 @@ pub mod api_keys {
type Operation = google_cloud_lro::internal::Operation<crate::model::Key, wkt::Empty>;
let polling_error_policy = self.0.stub.get_polling_error_policy(&self.0.options);
let polling_backoff_policy = self.0.stub.get_polling_backoff_policy(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
let mut poller_options = self.0.stub.get_poller_options(&self.0.options);
#[cfg(google_cloud_unstable_tracing)]
if let Some(ref mut details) = poller_options.tracing {
details.method_name =
"google_cloud_apikeys_v2::client::ApiKeys::undelete_key::until_done";
Expand All @@ -820,21 +773,7 @@ pub mod api_keys {
Ok(Operation::new(op))
};

#[cfg(google_cloud_unstable_tracing)]
{
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
polling_backoff_policy,
start,
query,
)
}
.with_options(poller_options)
}

#[cfg(not(google_cloud_unstable_tracing))]
use google_cloud_lro::internal::PollerExt;
{
google_cloud_lro::internal::new_unit_metadata_poller(
polling_error_policy,
Expand All @@ -843,6 +782,7 @@ pub mod api_keys {
query,
)
}
.with_options(poller_options)
}

/// Sets the value of [name][crate::model::UndeleteKeyRequest::name].
Expand Down
1 change: 0 additions & 1 deletion src/generated/api/apikeys/v2/src/stub.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ pub trait ApiKeys: std::fmt::Debug + Send + Sync {
std::sync::Arc::new(google_cloud_gax::exponential_backoff::ExponentialBackoff::default())
}

#[cfg(google_cloud_unstable_tracing)]
#[doc(hidden)]
/// Returns the poller options.
///
Expand Down
2 changes: 0 additions & 2 deletions src/generated/api/apikeys/v2/src/stub/dynamic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ pub trait ApiKeys: std::fmt::Debug + Send + Sync {
options: &crate::RequestOptions,
) -> std::sync::Arc<dyn google_cloud_gax::polling_backoff_policy::PollingBackoffPolicy>;

#[cfg(google_cloud_unstable_tracing)]
fn get_poller_options(
&self,
options: &crate::RequestOptions,
Expand Down Expand Up @@ -186,7 +185,6 @@ impl<T: super::ApiKeys> ApiKeys for T {
T::get_polling_backoff_policy(self, options)
}

#[cfg(google_cloud_unstable_tracing)]
fn get_poller_options(
&self,
options: &crate::RequestOptions,
Expand Down
3 changes: 0 additions & 3 deletions src/generated/api/apikeys/v2/src/tracing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,8 @@ where
info: *info::INSTRUMENTATION_CLIENT_INFO,
method: "client::ApiKeys::get_operation",
self.inner.get_operation(req, options));
#[cfg(google_cloud_unstable_tracing)]
google_cloud_lro::record_polling_attributes!(&_span);
let result = pending.await;
#[cfg(google_cloud_unstable_tracing)]
{
if google_cloud_lro::LroRecorder::current().is_some() {
match &result {
Expand Down Expand Up @@ -223,7 +221,6 @@ where
self.inner.get_polling_backoff_policy(options)
}

#[cfg(google_cloud_unstable_tracing)]
#[doc(hidden)]
fn get_poller_options(
&self,
Expand Down
Loading
Loading