Skip to content

feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing - #5897

Merged
haphungw merged 6 commits into
googleapis:mainfrom
haphungw:remove-lro-tracing-gate
Jul 10, 2026
Merged

feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing#5897
haphungw merged 6 commits into
googleapis:mainfrom
haphungw:remove-lro-tracing-gate

Conversation

@haphungw

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request stabilizes tracing and poller options across various generated Google Cloud clients by removing the google_cloud_unstable_tracing conditional compilation flags. It also exposes internal observability error types and helper functions by increasing their visibility to public. Regarding the feedback, a naming convention issue was identified in observability/errors.rs where a method returning an owned String was prefixed with as_ instead of to_.

Comment thread src/gax-internal/src/observability/errors.rs Outdated
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (f9f2d7c) to head (97e22d7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5897      +/-   ##
==========================================
- Coverage   97.69%   97.66%   -0.04%     
==========================================
  Files         244      246       +2     
  Lines       61351    62029     +678     
==========================================
+ Hits        59937    60578     +641     
- Misses       1414     1451      +37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw
haphungw force-pushed the remove-lro-tracing-gate branch 9 times, most recently from 6b13905 to 93df64f Compare June 18, 2026 23:49
@haphungw
haphungw force-pushed the remove-lro-tracing-gate branch 2 times, most recently from 5e0c2e0 to 8b8707b Compare July 9, 2026 17:46
@haphungw
haphungw force-pushed the remove-lro-tracing-gate branch from ba71a7a to c711054 Compare July 9, 2026 20:20
@haphungw
haphungw marked this pull request as ready for review July 9, 2026 21:44
@haphungw
haphungw requested review from a team as code owners July 9, 2026 21:44
@haphungw
haphungw requested a review from westarle July 9, 2026 21:44
haphungw added 2 commits July 9, 2026 22:20
Update librarian.yaml to use a pseudo-version instead of a commit hash to satisfy review feedback, and remove the unstable tracing cfg from driver tests.
Include missing generated files from additional services.
@haphungw
haphungw requested a review from a team as a code owner July 9, 2026 22:21
@haphungw
haphungw merged commit 4d8fe08 into googleapis:main Jul 10, 2026
41 checks passed
@haphungw
haphungw deleted the remove-lro-tracing-gate branch July 10, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants