Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translate): support faraday 1.x #4863

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Feb 24, 2020

Faraday 1.0 was released in January. This expands the dependency to allow the latest 0.x version and all 1.x versions. See also googleapis/signet#159 and googleapis/google-auth-library-ruby#252 for related upstream changes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2020
@dazuma dazuma requested a review from a team February 24, 2020 21:59
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM.

@dazuma dazuma merged commit 14ab11e into googleapis:master Mar 2, 2020
@dazuma dazuma deleted the translate-faraday branch March 2, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants