Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faraday #252

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Update faraday #252

merged 1 commit into from
Feb 24, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Feb 3, 2020

Faraday got updated and we over at manageiq were hoping maybe that you all might be amenable to letting people update so we can support ruby 2.7.

This is a pretty significant change since v0.12 is from April 01, 2017.

It's WIP because I don't think this can get in unless signet also gets an upgrade, though it's open.

Thanks!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@d-m-u d-m-u mentioned this pull request Feb 3, 2020
21 tasks
@dazuma
Copy link
Member

dazuma commented Feb 24, 2020

We're getting signet updated now. For signet, we'll be using ">= 0.17.3", "< 2.0", so maybe best to use the same for this library.

@d-m-u d-m-u changed the title [WIP] Update faraday Update faraday Feb 24, 2020
@dazuma dazuma added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2020
@dazuma
Copy link
Member

dazuma commented Feb 24, 2020

Signet release is done: https://rubygems.org/gems/signet/versions/0.13.0

Merging this, and will release a googleauth update shortly.

@dazuma dazuma merged commit de8e9e4 into googleapis:master Feb 24, 2020
@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 24, 2020

this is great, thanks so much @dazuma

@d-m-u d-m-u deleted the updating_faraday branch February 24, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants