Skip to content

Conversation

@dwsupplee
Copy link
Contributor

Until grpc/grpc#12123 is resolved we will need to rely on an older version of gRPC for builds to pass.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
@dwsupplee dwsupplee merged commit fc08eaf into googleapis:master Aug 9, 2017
@stanley-cheung
Copy link
Contributor

@dwsupplee Can you point me to a Travis CI build that failed before this?

@jdpedrie
Copy link
Contributor

jdpedrie commented Aug 9, 2017

@stanley-cheung
Copy link
Contributor

@jdpedrie Thanks for the info.

Is it possible to run these tests outside of Travis manually, with gRPC 1.4.4 and make sure the php binary was not compiled with the --enable-maintainer-zts configure flag?

You can check whether your php binary have that flag by running php-config --configure-options. So far I have isolated the issue to this particular flag (which Travis enabled by default). I just want to see if I can confirm this with another person.

Thanks very much for the help to narrow this down!

@dwsupplee
Copy link
Contributor Author

dwsupplee commented Aug 9, 2017

@stanley-cheung

I just received this error locally after upgrading gRPC 1.4.1 to 1.4.4 and running the tests:

E0809 18:17:17.843277000 140735272988672 sync_posix.c:60]              assertion failed: pthread_mutex_lock(mu) == 0

And the output of php-config --configure-options:

--prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --disable-dependency-tracking --sysconfdir=/private/etc --with-libdir=lib --enable-cli --with-iconv=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.Internal.sdk/usr --with-config-file-path=/etc --with-config-file-scan-dir=/Library/Server/Web/Config/php --with-libxml-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.Internal.sdk/usr --with-openssl=/usr/local/libressl/include

Strangely, I believe @jdpedrie has been running the tests locally using 1.4.4 on OSX as well without any errors.

Hope this helps! Let me know if there's anything else I can help provide.

Edit: Some additional info, this was running PHP 5.5.38

michaelbausor pushed a commit to michaelbausor/gcloud-php that referenced this pull request Aug 10, 2017
dwsupplee pushed a commit that referenced this pull request Aug 14, 2017
* Add options for entity calls in DatastoreSessionHandler

* Update @see docs

* temporarily require grpc-1.4.1 (#624)

* Address PR comments

* Fix line length

* Address PR comments

* Fix format violation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants