Skip to content

Conversation

@jdpedrie
Copy link
Contributor

@jdpedrie jdpedrie commented Aug 8, 2017

This change introduces client-generated Job IDs. It also adds support for user-specified job prefixes.

The goal of this feature is to make inserting jobs idempotent. I am concerned that I may not have quite captured that in this pull request. Job IDs are generated when BigQueryClient::runQueryAsJob() or the various Job-creating methods on Table are called. This means that multiple calls to those methods will result in different unique Job IDs, even if the configuration is identical.Those IDs are accessible after the call is executed, by invoking Job::id(). Currently there is not a means for a user to manually specify a Job ID (only a prefix); this means that one cannot retry with an existing Job ID.

If this is an issue, it could be mitigated without major changes to the client by adding an optional $jobId argument to the various job-creating methods' $options, along with documentation advising against using it except in well-defined circumstances.

@jdpedrie jdpedrie added the api: bigquery Issues related to the BigQuery API. label Aug 8, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2017
@jdpedrie
Copy link
Contributor Author

jdpedrie commented Aug 8, 2017

phpunit is getting hung up on a spanner unit test:

Starting test 'Google\Cloud\Tests\Unit\Spanner\Connection\GrpcTest::testCallBasicMethods with data set #0 ('listInstanceConfigs', array('projects/my-project'), array('projects/my-project', array(array(array('projects/my-project')))))'.

I'm investigating now!

@jdpedrie jdpedrie added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 8, 2017
@jdpedrie
Copy link
Contributor Author

jdpedrie commented Aug 9, 2017

test issue temporarily resolved by #624.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 10, 2017
@jdpedrie jdpedrie closed this Aug 14, 2017
@jdpedrie jdpedrie reopened this Aug 21, 2017
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 22, 2017
@jdpedrie jdpedrie closed this Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants