Skip to content

chore: migrate 38 modules (recommendationengine - workstations) to Librarian#13135

Merged
quartzmo merged 3 commits intogoogleapis:mainfrom
jskeet:batch-3
Oct 15, 2025
Merged

chore: migrate 38 modules (recommendationengine - workstations) to Librarian#13135
quartzmo merged 3 commits intogoogleapis:mainfrom
jskeet:batch-3

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Oct 14, 2025

Modules migrated:

  • recommendationengine
  • recommender
  • redis
  • resourcemanager
  • retail
  • scheduler
  • secretmanager
  • securesourcemanager
  • security
  • securitycenter
  • securitycentermanagement
  • securityposture
  • servicedirectory
  • servicehealth
  • shell
  • shopping
  • speech
  • storagebatchoperations
  • storageinsights
  • storagetransfer
  • streetview
  • support
  • talent
  • telcoautomation
  • texttospeech
  • tpu
  • trace
  • translate
  • video
  • videointelligence
  • vision
  • visionai
  • vmwareengine
  • vpcaccess
  • webrisk
  • websecurityscanner
  • workflows
  • workstations

@jskeet jskeet requested review from a team and quartzmo October 14, 2025 16:37
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Oct 14, 2025

We should wait until generation has run on the current set of modules before merging this.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Oct 14, 2025

Will look into the config schema error.

@jskeet jskeet marked this pull request as draft October 14, 2025 16:40
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Oct 14, 2025

Running librarian generate I see a difference in visionai/apiv1/doc.go. Will talk about that with @quartzmo when we meet.

@jskeet jskeet marked this pull request as ready for review October 14, 2025 18:11
@jskeet jskeet added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 14, 2025
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Oct 14, 2025

We understand the difference in visionai/apiv1/doc.go - we believe this is because the first service encountered is used to construct the sample client; when using Bazel this depends on the order of the protos in the BUILD.bazel file, whereas now the protos are just alphabetical.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Oct 14, 2025

@quartzmo Just a reminder to review this if you have a chance so I can merge in my morning if the generation of today's modules works.

@jskeet jskeet removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 15, 2025
@quartzmo quartzmo changed the title chore: migrate remaining 38 "simple" modules to Librarian chore: migrate 38 modules (recommendationengine - workstations) to Librarian Oct 15, 2025
@quartzmo quartzmo merged commit 2da2244 into googleapis:main Oct 15, 2025
47 checks passed
@jskeet jskeet deleted the batch-3 branch October 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants