Skip to content

chore: librarian release pull request: 20251016T175757Z#13167

Merged
jskeet merged 3 commits intomainfrom
librarian-20251016T175757Z
Oct 20, 2025
Merged

chore: librarian release pull request: 20251016T175757Z#13167
jskeet merged 3 commits intomainfrom
librarian-20251016T175757Z

Conversation

@cloud-sdk-librarian-robot
Copy link
Copy Markdown
Collaborator

@cloud-sdk-librarian-robot cloud-sdk-librarian-robot commented Oct 16, 2025

Librarian Version: v0.0.0-20251016162528-bcb914ac67af
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go:latest

secretmanager: 1.16.0

1.16.0 (2025-10-16)

Features

  • Conditionally enable AllowHardBoundTokens (ddc086c)

@cloud-sdk-librarian-robot cloud-sdk-librarian-robot requested a review from a team October 16, 2025 17:58
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 16, 2025
@jskeet
Copy link
Copy Markdown
Contributor

jskeet commented Oct 16, 2025

@quartzmo Apologies, this is on me - not sure how this got through my check for "safe" APIs to migrate, but there was clearly an OwlBot PR merged after the last release.

I'll check other APIs tomorrow to check whether I messed up elsewhere...

@quartzmo
Copy link
Copy Markdown
Member

@jskeet No problem, do you think we should just push a commit to this PR to fix secretmanager/CHANGES.md in place?

@jskeet
Copy link
Copy Markdown
Contributor

jskeet commented Oct 16, 2025

@jskeet No problem, do you think we should just push a commit to this PR to fix secretmanager/CHANGES.md in place?

And edit the PR description - yes, I think that's the best option. I can do it tomorrow if you'd like - no reason you should pay the price for my mistake!

@jskeet
Copy link
Copy Markdown
Contributor

jskeet commented Oct 17, 2025

I'll merge this on Monday morning.

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2025
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2025
@quartzmo
Copy link
Copy Markdown
Member

Kokoro succeeded.

@jskeet jskeet removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 20, 2025
@jskeet jskeet merged commit 3d8d0a9 into main Oct 20, 2025
11 checks passed
@jskeet jskeet deleted the librarian-20251016T175757Z branch October 20, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants