Skip to content

fix(spanner): explicitly disable gRPC new pickfirst. #12206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahul2393 merged 2 commits into from
May 7, 2025
Merged

fix(spanner): explicitly disable gRPC new pickfirst. #12206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e95692
fix: explicitly disable gRPC new pickfirst.
HailongWen May 6, 2025
f1aee0d
Merge branch 'main' into main
rahul2393 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spanner/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,15 @@ func newClientWithConfig(ctx context.Context, database string, config ClientConf
ctx = trace.StartSpan(ctx, "cloud.google.com/go/spanner.NewClient")
defer func() { trace.EndSpan(ctx, err) }()

// Explicitly disable some gRPC experiments as they are not stable yet.
gRPCPickFirstEnvVarName := "GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST"

@HailongWen HailongWen May 6, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this env var only applies to DirectPath and will be a no-op to existing CloudPath users.

if os.Getenv(gRPCPickFirstEnvVarName) == "" {
err := os.Setenv(gRPCPickFirstEnvVarName, "false")
if err != nil {
logf(config.Logger, "Error overriding GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST to false: %v. Ignoring.", err)
}
}

// Append emulator options if SPANNER_EMULATOR_HOST has been set.
if emulatorAddr := os.Getenv("SPANNER_EMULATOR_HOST"); emulatorAddr != "" {
schemeRemoved := regexp.MustCompile("^(http://|https://|passthrough:///)").ReplaceAllString(emulatorAddr, "")
Expand Down