fix(spanner): explicitly disable gRPC new pickfirst. - #12206
Merged
Conversation
As seen in b/415354418, this new experimental feature introduced by grpc/grpc-go#8126 is not yet stable and may cause intermittent CloudPath fallbacks. As a user of the OSS gRPC library, CS library should explicitly disable it until the underlying issue is fixed.
HailongWen
commented
May 6, 2025
| defer func() { trace.EndSpan(ctx, err) }() | ||
|
|
||
| // Explicitly disable some gRPC experiments as they are not stable yet. | ||
| gRPCPickFirstEnvVarName := "GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST" |
Contributor
Author
There was a problem hiding this comment.
Note: this env var only applies to DirectPath and will be a no-op to existing CloudPath users.
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
approved these changes
May 7, 2025
rahul2393
changed the title
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
2FaceS-bit
pushed a commit
to 2FaceS-bit/google-cloud-go
that referenced
this pull request
May 12, 2025
As seen in b/415354418, this new experimental feature introduced by grpc/grpc-go#8126 is not yet stable and may cause intermittent CloudPath fallbacks. As a user of the OSS gRPC library, CS library should explicitly disable it until the underlying issue is fixed. Co-authored-by: rahul2393 <irahul@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in b/415354418, this new experimental feature introduced by grpc/grpc-go#8126 is not yet stable and may cause intermittent CloudPath fallbacks.
As a user of the OSS gRPC library, CS library should explicitly disable it until the underlying issue is fixed.