feat(gengapic): conditionally enable directpath for storagecontrol#1634
Merged
tritone merged 3 commits intogoogleapis:mainfrom Aug 1, 2025
Merged
feat(gengapic): conditionally enable directpath for storagecontrol#1634tritone merged 3 commits intogoogleapis:mainfrom
tritone merged 3 commits intogoogleapis:mainfrom
Conversation
Contributor
Author
quartzmo
approved these changes
Jun 4, 2025
Member
|
If it ever turns out that the test enablement for |
Contributor
Author
Thanks for the quick approval. Could you help merge it once @tritone also LGTMs on this approach? |
tritone
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given storagecontrol being the only use case we know, hard-coding it in the generator seems the most convenient approach.
To uniquely identity the service, it uses the API and service name joined by "/".