Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using macos-14 with github action #98

Merged
merged 1 commit into from
Apr 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- run: xvfb-run flutter pub run test -p vm,chrome,firefox
macos:
name: webcrypto on macOS desktop / Chrome
runs-on: macos-latest
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- uses: subosito/flutter-action@v2
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
- run: flutter pub run test -p vm,chrome,firefox
ios:
name: webcrypto on iOS emulator (iPhone)
runs-on: macos-latest
runs-on: macos-14
steps:
- uses: actions/checkout@v4
- uses: subosito/flutter-action@v2
Expand All @@ -108,19 +108,15 @@ jobs:
flutter config --no-analytics
- uses: futureware-tech/simulator-action@v3
with:
model: 'iPhone 12'
model: 'iPhone 15'
- run: flutter pub get
- run: flutter test integration_test/webcrypto_test.dart -d iphone
working-directory: ./example
android:
name: webcrypto on Android emulator
runs-on: macos-latest
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think ubuntu instanced had good VM features

steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: '11'
- uses: subosito/flutter-action@v2
with:
channel: 'stable'
Expand All @@ -129,6 +125,11 @@ jobs:
run: |
flutter config --no-analytics
- run: flutter pub get
- name: Enable KVM
run: |
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
- name: Run flutter test integration_test/webcrypto_test.dart -d android
uses: reactivecircus/android-emulator-runner@v2
with:
Expand Down
Loading