Using macos-14 with github action #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Apr 5, 2024
| - run: flutter pub get | ||
| - run: flutter test integration_test/webcrypto_test.dart -d iphone | ||
| working-directory: ./example | ||
| android: | ||
| name: webcrypto on Android emulator | ||
| runs-on: macos-latest | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
I didn't think ubuntu instanced had good VM features
jonasfj
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By selecting macos-14, m1 machine is available.
I have created a PR for the machine as it is expected to improve the speed of execution of Integration test. Also, I changed to ubuntu-latest because it seems to be hard to run Android integration test on m1 chip.
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
ReactiveCircus/android-emulator-runner#350
link #93