Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that the filename are case sensitive #300

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

Tristramg
Copy link
Contributor

Closes #297

@skinkie
Copy link
Contributor

skinkie commented Dec 20, 2021

Voting ends 2021-20-27 at 23:59:59 UTC.

@skinkie
Copy link
Contributor

skinkie commented Dec 20, 2021

+1 OpenGeo

@scmcca
Copy link
Contributor

scmcca commented Dec 20, 2021

I'll repeat my #297 (comment). Should we merge this directly with no vote since it is a minor and straightforward clarification? I'm happy to follow the process as well!

@skinkie
Copy link
Contributor

skinkie commented Dec 20, 2021

I'll repeat my #297 (comment). Should we merge this directly with no vote since it is a minor and straightforward clarification? I'm happy to follow the process as well!

I think this is an issue. @Tristramg found a producer that did not implement this "correctly" hence it is a breaking change, at least for producers. I would like to follow the voting period, so that this producer can also be informed about this issue.

@scmcca scmcca added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule cla: yes labels Dec 20, 2021
@google-cla
Copy link

google-cla bot commented Dec 20, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot removed the cla: yes label Dec 20, 2021
@botanize
Copy link
Contributor

+1 Metro Transit

@paulswartz
Copy link
Contributor

+1 MBTA

@scmcca
Copy link
Contributor

scmcca commented Jan 7, 2022

To be clear, according to the specification amendment process the steps taken to call a vote so far have not been legitimate.

If we are passing this through a vote as @skinkie has established, we should do it properly.

@Tristramg As the advocate of this PR, please read up on the specification amendment process and follow the steps so we can proceed! Looking forward to getting this merged.

@skinkie
Copy link
Contributor

skinkie commented Jan 20, 2022

+1 OpenGeo

@scmcca scmcca added the Status: Voting Pull Requests where the advocate has called for a vote as described in the changes.md label Jan 20, 2022
@Tristramg
Copy link
Contributor Author

Hello,

This PR had been announced on the mailing list for 10 days and the vote has been formally opened today and will continue until 2022-01-27 23:59:59 UTC

As the process states:

Votes before the start of the voting period are not considered.

@botanize and @paulswartz would you mind re-casting your vote as the previous won’t be considered.

I apologize for the troubles caused by lack of rigor to follow the process.

@gcamp
Copy link
Contributor

gcamp commented Jan 20, 2022

+1 Transit

@flocsy
Copy link
Contributor

flocsy commented Jan 21, 2022

+1 Moovit

@abyrd
Copy link

abyrd commented Jan 21, 2022

+1 Conveyal

@botanize
Copy link
Contributor

+1 Metro Transit

@paulswartz
Copy link
Contributor

+1 MBTA

@mgilligan
Copy link

+1, TriMet

@scmcca scmcca merged commit 0033573 into google:master Jan 28, 2022
scmcca pushed a commit to MobilityData/transit that referenced this pull request Feb 11, 2022
commit 2e6887e
Author: scmcca <[email protected]>
Date:   Wed Feb 2 12:42:10 2022 -0500

    [Formatting fix] Add newlines before lists

    Improved syntax for different markdown parsers

commit 0033573
Author: Tristram Gräbener <[email protected]>
Date:   Fri Jan 28 15:54:00 2022 +0100

    Specify that the filename are case sensitive (google#300)

    Closes google#297

commit 23d877e
Author: scott christian mccallum <[email protected]>
Date:   Tue Jan 18 19:09:46 2022 -0500

    "Fields" and "Values" as non-header (google#302)
@scmcca scmcca removed the Status: Voting Pull Requests where the advocate has called for a vote as described in the changes.md label Apr 26, 2022
isabelle-dr pushed a commit to MobilityData/transit that referenced this pull request Dec 19, 2023
* Squashed commit of the following:

commit 2e6887e
Author: scmcca <[email protected]>
Date:   Wed Feb 2 12:42:10 2022 -0500

    [Formatting fix] Add newlines before lists

    Improved syntax for different markdown parsers

commit 0033573
Author: Tristram Gräbener <[email protected]>
Date:   Fri Jan 28 15:54:00 2022 +0100

    Specify that the filename are case sensitive (google#300)

    Closes google#297

commit 23d877e
Author: scott christian mccallum <[email protected]>
Date:   Tue Jan 18 19:09:46 2022 -0500

    "Fields" and "Values" as non-header (google#302)

* Squashed commit of the following:

commit 9d5ebf1
Author: Guillaume Campagna <[email protected]>
Date:   Tue Jul 26 17:09:35 2022 -0400

    Add trip-to-trip transfers with in-seat option (google#303)

    * Add trip-to-trip transfers with in-seat option

    * Fix stop_id are **Conditionally Required** and formatting

    * Add clarification about potential conflict

    * Fix typo

    Co-authored-by: Leonard Ehrenfried <[email protected]>

    Co-authored-by: Nicholas Paun <[email protected]>
    Co-authored-by: Leonard Ehrenfried <[email protected]>

commit a132709
Author: McKenzie Maidl <[email protected]>
Date:   Tue Jul 26 13:58:04 2022 -0700

    addition of cause_detail and effect_detail to the spec (google#332)

commit 8993a24
Author: Zsombor Welker <[email protected]>
Date:   Mon Jul 25 14:49:40 2022 +0200

    Add WheelchairAccessible documentation (google#340)

* Update README.md (#63)

* issue templates

* update use cases section

* update contact links

* rename

* Delete .github/ISSUE_TEMPLATE/spec_improvement.yml

---------

Co-authored-by: scmcca <[email protected]>
Co-authored-by: omar-kabbani <[email protected]>
Co-authored-by: Emma Jae Blue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-sensitivity of filenames
10 participants