Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-sensitivity of filenames #297

Closed
Tristramg opened this issue Dec 15, 2021 · 6 comments · Fixed by #300
Closed

Case-sensitivity of filenames #297

Tristramg opened this issue Dec 15, 2021 · 6 comments · Fixed by #300

Comments

@Tristramg
Copy link
Contributor

The specifications says that the columns names are case-sensitive.

However nothing is specified for filenames. Should a Routes.txt be a valid file for the routes or not.

I have no strong opinion here, but I believe the specification should be explicit if can be allowed or not.

@skinkie
Copy link
Contributor

skinkie commented Dec 15, 2021

I (hoped) it was explicit from all the examples. But I guess you have found a producer that uses capitals?

@Tristramg
Copy link
Contributor Author

Tristramg commented Dec 15, 2021 via email

@scmcca
Copy link
Contributor

scmcca commented Dec 15, 2021

We can add it as a point to the "File Requirements" section. Perhaps we can amend the 3rd point to say:

All file and field names are case-sensitive.

@Tristramg
Copy link
Contributor Author

Seems good for me. What would be the following steps to actually amend that point?

@skinkie
Copy link
Contributor

skinkie commented Dec 20, 2021

Seems good for me. What would be the following steps to actually amend that point?

Think you want to create a pull request, with an immediate vote, and announce it on the mailinglist.

@scmcca
Copy link
Contributor

scmcca commented Dec 20, 2021

@Tristramg Please see the specification amendment process.

AFAIK immediate votes are not the norm when opening a pull request (usually 7 days of discussion are needed first). Also voting can only be called by the advocate of the pull request.

At any rate, I almost think we can merge this one directly since it is a fairly minor and straightforward clarification?

scmcca pushed a commit that referenced this issue Jan 28, 2022
scmcca pushed a commit to MobilityData/transit that referenced this issue Feb 11, 2022
commit 2e6887e
Author: scmcca <[email protected]>
Date:   Wed Feb 2 12:42:10 2022 -0500

    [Formatting fix] Add newlines before lists

    Improved syntax for different markdown parsers

commit 0033573
Author: Tristram Gräbener <[email protected]>
Date:   Fri Jan 28 15:54:00 2022 +0100

    Specify that the filename are case sensitive (google#300)

    Closes google#297

commit 23d877e
Author: scott christian mccallum <[email protected]>
Date:   Tue Jan 18 19:09:46 2022 -0500

    "Fields" and "Values" as non-header (google#302)
isabelle-dr pushed a commit to MobilityData/transit that referenced this issue Dec 19, 2023
* Squashed commit of the following:

commit 2e6887e
Author: scmcca <[email protected]>
Date:   Wed Feb 2 12:42:10 2022 -0500

    [Formatting fix] Add newlines before lists

    Improved syntax for different markdown parsers

commit 0033573
Author: Tristram Gräbener <[email protected]>
Date:   Fri Jan 28 15:54:00 2022 +0100

    Specify that the filename are case sensitive (google#300)

    Closes google#297

commit 23d877e
Author: scott christian mccallum <[email protected]>
Date:   Tue Jan 18 19:09:46 2022 -0500

    "Fields" and "Values" as non-header (google#302)

* Squashed commit of the following:

commit 9d5ebf1
Author: Guillaume Campagna <[email protected]>
Date:   Tue Jul 26 17:09:35 2022 -0400

    Add trip-to-trip transfers with in-seat option (google#303)

    * Add trip-to-trip transfers with in-seat option

    * Fix stop_id are **Conditionally Required** and formatting

    * Add clarification about potential conflict

    * Fix typo

    Co-authored-by: Leonard Ehrenfried <[email protected]>

    Co-authored-by: Nicholas Paun <[email protected]>
    Co-authored-by: Leonard Ehrenfried <[email protected]>

commit a132709
Author: McKenzie Maidl <[email protected]>
Date:   Tue Jul 26 13:58:04 2022 -0700

    addition of cause_detail and effect_detail to the spec (google#332)

commit 8993a24
Author: Zsombor Welker <[email protected]>
Date:   Mon Jul 25 14:49:40 2022 +0200

    Add WheelchairAccessible documentation (google#340)

* Update README.md (#63)

* issue templates

* update use cases section

* update contact links

* rename

* Delete .github/ISSUE_TEMPLATE/spec_improvement.yml

---------

Co-authored-by: scmcca <[email protected]>
Co-authored-by: omar-kabbani <[email protected]>
Co-authored-by: Emma Jae Blue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants