dashboard/app: add "[syzbot] " constant

[tarasmadan]

It contributes to #4317 unblocking.

[tarasmadan]

@a-nogikh ptal

[a-nogikh]

Are there global ignore strings list? Maybe [syzbot] could belong there. I think tests are easier to follow if it's a string rather than if it's some referenced const.

Also, here we patch it when it's used more explicitly, but there are also cases where it's a part of a title like "[syzbot] fix bug title" from email_test.go, and it was just not caught by the linter.

[tarasmadan]

No. The only alternative I see is to use "// nolint: goconst" in every line with "[syzbot]".
If it looks better for you please let me know.

[a-nogikh]

Maybe there are at least per-file annotations? There must be.

[tarasmadan]

https://golangci-lint.run/usage/linters/#goconst is about configuration.
The required flexibility is absent.

jgautheron/goconst#22 to increase this 3 days long discussion value.
Once landed, golangci-lint change will be needed to support the new flag.

[tarasmadan]

Added to goconst tool.
Next actions are to:

1. Wait for dependabot update on https://github.com/golangci/golangci-lint.
2. Add required option support or just request the feature there.

[codecov]

Codecov Report

Merging #4323 (032a471) into master (fc59b78) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

[tarasmadan]

golangci/golangci-lint#4200 landed the feature.
I think we'll have it the next golangci-lint release.

[tarasmadan]

#4374 landed it