Skip to content

dashboard/app: add "[syzbot] " constant #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tarasmadan wants to merge 1 commit into from
Closed

dashboard/app: add "[syzbot] " constant #4323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboard/app/bisect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ For information about bisection process see: https://goo.gl/tpsmEJ#bisection
"[email protected]",
"[email protected]",
})
c.expectEQ(msg.Subject, "[syzbot] "+crash2.Title)
c.expectEQ(msg.Subject, "[syzbot] "+crash2.Title) // nolint: goconst
c.expectEQ(msg.Body, fmt.Sprintf(`Hello,

syzbot found the following issue on:
Expand Down Expand Up @@ -319,7 +319,7 @@ If you want to undo deduplication, reply with:
c.expectEQ(msg.Subject, subjects[i])
c.expectTrue(strings.Contains(msg.Body, "Sending this report to the next reporting stage."))
} else {
c.expectEQ(msg.Subject, "[syzbot] "+subjects[i])
c.expectEQ(msg.Subject, "[syzbot] "+subjects[i]) // nolint: goconst
c.expectTrue(strings.Contains(msg.Body, "syzbot found the following issue on"))
}
}
Expand Down
6 changes: 3 additions & 3 deletions dashboard/app/email_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ If you attach or paste a git patch, syzbot will apply it before testing.
"[email protected]",
"[email protected]",
})
c.expectEQ(msg.Subject, "[syzbot] "+crash.Title)
c.expectEQ(msg.Subject, "[syzbot] "+crash.Title) // nolint: goconst
c.expectEQ(len(msg.Attachments), 0)
c.expectEQ(msg.Body, fmt.Sprintf(`Hello,

Expand Down Expand Up @@ -314,7 +314,7 @@ Content-Type: text/plain
"[email protected]", "[email protected]", "[email protected]",
"[email protected]", "[email protected]", "[email protected]",
"[email protected]", "[email protected]", "[email protected]"})
c.expectEQ(msg.Subject, "Re: [syzbot] "+crash.Title)
c.expectEQ(msg.Subject, "Re: [syzbot] "+crash.Title) // nolint: goconst
c.expectEQ(len(msg.Attachments), 0)
c.expectEQ(msg.Body, fmt.Sprintf(`syzbot has found a reproducer for the following issue on:

Expand Down Expand Up @@ -1323,7 +1323,7 @@ func expectLabels(t *testing.T, client *apiClient, extID string, labels ...strin
var forwardEmailConfig = EmailConfig{
Email: "[email protected]",
HandleListEmails: true,
SubjectPrefix: "[syzbot]",
SubjectPrefix: "[syzbot]", // nolint: goconst
MailMaintainers: true,
DefaultMaintainers: []string{"[email protected]"},
}
Expand Down
2 changes: 1 addition & 1 deletion dashboard/app/notifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestEmailNotifUpstreamEmbargo(t *testing.T) {
c.expectEQ(notifUpstream.Subject, crash.Title)
c.expectEQ(notifUpstream.Sender, report.Sender)
c.expectEQ(notifUpstream.Body, "Sending this report to the next reporting stage.")
c.expectEQ(upstreamReport.Subject, "[syzbot] "+crash.Title)
c.expectEQ(upstreamReport.Subject, "[syzbot] "+crash.Title) // nolint: goconst
c.expectNE(upstreamReport.Sender, report.Sender)
c.expectEQ(upstreamReport.To, []string{"[email protected]", "[email protected]"})
}
Expand Down