Add shared library variant for libshaderc #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AWoloszyn PTAL! |
|
Hey! Sorry about the delay, somehow my GitHub emails are getting mis-classified as junk. |
|
Again, sorry about the delay. |
|
No problem :) Added the tests and ran them locally. My understanding is that they will run automatically on Travis via CTest correct? |
AWoloszyn
approved these changes
Sep 11, 2017
|
Thanks for the review! Testing passed, @antiagainst or @AWoloszyn can one of you merge this? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for a CQ dry-run. Heavily based off #342