-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shared library variant for libshaderc #342
Conversation
Adds target shaderc_shared, which builds libshaderc as a shared library. This is required for shipping the library on Windows, where static libraries are not feasible.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Hi @nsubtil, do you still intended to contribute this PR? Could you please resolve the conflicts and make it pass the tests? Thanks! |
Yes, I'm still interested, but I need to do our due diligence for the CLA
first. This had fallen off my radar, thanks for pinging me. I'll try to get
this resolved soon.
…On Mon, Jul 24, 2017 at 9:36 PM, Lei Zhang ***@***.***> wrote:
Hi @nsubtil <https://github.com/nsubtil>, do you still intended to
contribute this PR? Could you please resolve the conflicts and make it pass
the tests? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF66M-1kKN978j7e0iZXj_Mn1EAMuskDks5sRXDagaJpZM4NplFq>
.
|
Cool, thanks! :) |
I'm also interested in this. On Windows there will be an additional SHADERC_EXPORT mechanism needed to make shaderc dlls work. |
@nsubtil I'm picking this up. |
Thanks @Kangz. I'll keep an eye out for updates. Happy to help if I can, though I haven't really had much time for this in the past weeks. |
CLAs look good, thanks! |
Agreed. Thanks for the help on this! |
Adds target shaderc_shared, which builds libshaderc as a shared library. This
is required for shipping the library on Windows, where static libraries are not
feasible.