Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared library variant for libshaderc #342

Closed
wants to merge 1 commit into from

Conversation

nsubtil
Copy link

@nsubtil nsubtil commented May 29, 2017

Adds target shaderc_shared, which builds libshaderc as a shared library. This
is required for shipping the library on Windows, where static libraries are not
feasible.

Adds target shaderc_shared, which builds libshaderc as a shared library. This
is required for shipping the library on Windows, where static libraries are not
feasible.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@antiagainst
Copy link
Contributor

Hi @nsubtil, do you still intended to contribute this PR? Could you please resolve the conflicts and make it pass the tests? Thanks!

@nsubtil
Copy link
Author

nsubtil commented Jul 27, 2017 via email

@antiagainst
Copy link
Contributor

Cool, thanks! :)

@Kangz
Copy link
Collaborator

Kangz commented Aug 25, 2017

I'm also interested in this. On Windows there will be an additional SHADERC_EXPORT mechanism needed to make shaderc dlls work.

@Kangz
Copy link
Collaborator

Kangz commented Aug 29, 2017

@nsubtil I'm picking this up.

@nsubtil
Copy link
Author

nsubtil commented Aug 29, 2017

Thanks @Kangz. I'll keep an eye out for updates. Happy to help if I can, though I haven't really had much time for this in the past weeks.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@Kangz
Copy link
Collaborator

Kangz commented Sep 12, 2017

@nsubtil, #366 landed so this PR could be closed.

@nsubtil
Copy link
Author

nsubtil commented Sep 12, 2017

Agreed. Thanks for the help on this!

@nsubtil nsubtil closed this Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants