Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix sample type menu entry ids with "sampletype-". #792

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Prefix sample type menu entry ids with "sampletype-". #792

merged 1 commit into from
Aug 8, 2023

Commits on Aug 8, 2023

  1. Prefix sample type menu entry ids with "sampletype-". 

    Previously, we would use the sample type name as the HTML id for the
corresponding menu entry. However some profiles contain sample type
names that conflict with other HTML ids we use (in particular, the
sample type name "sample" conflicted with a different id). Remove this
name clash by prefixing every menu entry with "sampletype-".

some profiles caused the Javascript to break bec
    @ghemawat
    ghemawat committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f2511f9 View commit details
    Browse the repository at this point in the history