Prefix sample type menu entry ids with "sampletype-". #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 66.99% 66.99%
=======================================
Files 45 45
Lines 9862 9862
=======================================
Hits 6607 6607
Misses 2795 2795
Partials 460 460 |
Louis-Ye
previously approved these changes
Aug 8, 2023
internal/driver/html/common.js
Outdated
| function setSampleIndexLink(id) { | ||
| const elem = document.getElementById(id); | ||
| function setSampleIndexLink(si) { | ||
| const elem = document.getElementById('sampletype-'+si); |
There was a problem hiding this comment.
nit: I think the grammar convention in this file is having space before/after the operator +. Can you change it to that?
Previously, we would use the sample type name as the HTML id for the corresponding menu entry. However some profiles contain sample type names that conflict with other HTML ids we use (in particular, the sample type name "sample" conflicted with a different id). Remove this name clash by prefixing every menu entry with "sampletype-". some profiles caused the Javascript to break bec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would use the sample type name as the HTML id for the corresponding menu entry. However some profiles contain sample type names that conflict with other HTML ids we use (in particular, the sample type name "sample" conflicted with a different id). Remove this name clash by prefixing every menu entry with "sampletype-".