arrow: Enable more compression libraries for Arrow #12320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to find potentially more issues inside the Arrow C++ codebase.
Contributor
Author
|
pitrou is either the primary contact or is in the CCs list of projects/arrow. |
Contributor
Author
|
Hmm, it looks like Snappy tries to force |
We should probably fix the cmake file for snappy to not set anything regarding rtti. |
DavidKorczynski
approved these changes
Aug 12, 2024
Contributor
Author
That's a good point. We should probably patch Snappy's CMake config in our build setup. Edit: opened apache/arrow#43688 for it |
DavidKorczynski
pushed a commit
that referenced
this pull request
Aug 21, 2024
In PR #12320, we enabled more compression algorithms for Arrow C++, but had to disable Snappy because of build issues. Since then, the Arrow project merged a PR (apache/arrow#43706) which enables RTTI when building Snappy. Therefore, we can now enable Snappy in the OSS-Fuzz builds of Arrow C++ as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may allow to find potentially more issues inside the Arrow C++ codebase.