Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Aug 8, 2024

  1. Add fuzz seeds with newer datatypes such as Run-End Encoded and String Views
  2. Add fuzz seeds with buffer compression
  3. Build seed corpus generation utilities even when fuzzing isn't enabled, for convenience

@github-actions
Copy link

github-actions bot commented Aug 8, 2024

⚠️ GitHub issue #38041 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member Author

pitrou commented Aug 8, 2024

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@pitrou
Copy link
Member Author

pitrou commented Aug 8, 2024

Ok, test-build-cpp-fuzz will require google/oss-fuzz#12320 to pass successfully

pitrou added 2 commits August 14, 2024 14:31
1. Add fuzz seeds with newer datatypes such as Run-End Encoded and String Views
2. Add fuzz seeds with buffer compression
3. Build seed corpus generation utilities even when fuzzing isn't enabled, for convenience
@pitrou pitrou force-pushed the gh38041-improve-ipc-fuzz-seed branch from 09c70bd to 9f6f1f6 Compare August 14, 2024 12:32
@pitrou
Copy link
Member Author

pitrou commented Aug 14, 2024

@github-actions crossbow submit -g cpp

@github-actions

This comment was marked as outdated.

@pitrou pitrou marked this pull request as ready for review August 14, 2024 13:01
@pitrou pitrou requested review from bkietz and felipecrv August 14, 2024 13:01
Result<PlatformFilename> PrepareDirectory(const std::string& dir) {
ARROW_ASSIGN_OR_RAISE(auto dir_fn, PlatformFilename::FromString(dir));
RETURN_NOT_OK(::arrow::internal::CreateDir(dir_fn));
return std::move(dir_fn);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this would meet same problem ( #41025 ) in gcc 7.5.0, sigh...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. #41025 involved an implicit conversion from unique_ptr to shared_ptr, IIUC, which isn't the case here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would not casting implicit cast PlatformFilename to Result<PlatformFilename> or did I miss something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #41025 the cast is from std::unique_ptr to Result<std::shared_ptr>, which is more complex (there are two cascaded casts).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try anyway.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Aug 14, 2024
@apache apache deleted a comment from github-actions bot Aug 14, 2024
@github-actions
Copy link

Unable to match any tasks for `test-r-rstudio-r-base-4.1-opensuse153`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/10389980694

@pitrou
Copy link
Member Author

pitrou commented Aug 14, 2024

@github-actions crossbow submit -g cpp -g r

@apache apache deleted a comment from github-actions bot Aug 14, 2024
@github-actions
Copy link

Revision: 9f6f1f6

Submitted crossbow builds: ursacomputing/crossbow @ actions-92e99ffb33

Task Status
r-binary-packages GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-clang-sanitizer GitHub Actions
test-r-depsource-bundled Azure
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-minimal-build Azure
test-r-offline-maximal GitHub Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-release-latest Azure
test-r-rocker-r-ver-latest Azure
test-r-rstudio-r-base-4.1-opensuse155 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-r-sanitizer GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Aug 14, 2024

CI failures look unrelated for now.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Aug 14, 2024
@pitrou pitrou merged commit f518d6b into apache:main Aug 15, 2024
@pitrou pitrou removed the awaiting merge Awaiting merge label Aug 15, 2024
@pitrou pitrou deleted the gh38041-improve-ipc-fuzz-seed branch August 15, 2024 08:41
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit f518d6b.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants