-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-38041: [C++][CI] Improve IPC fuzzing seed corpus #43621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, |
1. Add fuzz seeds with newer datatypes such as Run-End Encoded and String Views 2. Add fuzz seeds with buffer compression 3. Build seed corpus generation utilities even when fuzzing isn't enabled, for convenience
09c70bd to
9f6f1f6
Compare
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
| Result<PlatformFilename> PrepareDirectory(const std::string& dir) { | ||
| ARROW_ASSIGN_OR_RAISE(auto dir_fn, PlatformFilename::FromString(dir)); | ||
| RETURN_NOT_OK(::arrow::internal::CreateDir(dir_fn)); | ||
| return std::move(dir_fn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this would meet same problem ( #41025 ) in gcc 7.5.0, sigh...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. #41025 involved an implicit conversion from unique_ptr to shared_ptr, IIUC, which isn't the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this would not casting implicit cast PlatformFilename to Result<PlatformFilename> or did I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #41025 the cast is from std::unique_ptr to Result<std::shared_ptr>, which is more complex (there are two cascaded casts).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try anyway.
|
|
@github-actions crossbow submit -g cpp -g r |
|
Revision: 9f6f1f6 Submitted crossbow builds: ursacomputing/crossbow @ actions-92e99ffb33 |
|
CI failures look unrelated for now. |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit f518d6b. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Uh oh!
There was an error while loading. Please reload this page.