Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove an obsolete workaround from .bazelrc" #1103

Merged
merged 1 commit into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. Revert "Remove an obsolete workaround from .bazelrc"

    This reverts commit de7615f.
    
    It turns out that --cpu command line option will be silently ignored
    with Bazel 7.0 and later unless
    
      --noincompatible_enable_cc_toolchain_resolution
    
    option is specified [1]. Otherwise 'mozc_tip32.dll' will be built as
    a 64-bit executable.
    
    This is a temporary workaround until until we fully migrate to
    
    --platforms
    
    command line option [2].
    
    This commit only affects Windows build with Bazel. Other build
    configurations such as GYP build on Windows are not affected.
    
    Closes google#1102.
    
     [1]: bazelbuild/bazel#7260
     [2]: https://bazel.build/concepts/platforms
    yukawa committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e223ace View commit details
    Browse the repository at this point in the history