Revert "Remove an obsolete workaround from .bazelrc"
#1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de7615f. It turns out that --cpu command line option will be silently ignored with Bazel 7.0 and later unless --noincompatible_enable_cc_toolchain_resolution option is specified [1]. Otherwise 'mozc_tip32.dll' will be built as a 64-bit executable. This is a temporary workaround until until we fully migrate to --platforms command line option [2]. This commit only affects Windows build with Bazel. Other build configurations such as GYP build on Windows are not affected. Closes google#1102. [1]: bazelbuild/bazel#7260 [2]: https://bazel.build/concepts/platforms
|
We have merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit de7615f.
It turns out that
--cpucommand line option will be silently ignored with Bazel 7.0 and later unless--noincompatible_enable_cc_toolchain_resolutionoption is specified. Otherwisemozc_tip32.dllwill be built as a 64-bit executable.This is a temporary workaround until until we fully migrate to
--platformscommand line option.This commit only affects Windows build with Bazel. Other build configurations such as GYP build on Windows are not affected.
Closes #1102
Issue IDs
mozc_tip32.dllbuild with Bazel is not 32-bit binary #1102Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
Mozc64.msimozc_tip32.dllis built as a 32-bit executable.