Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_runner logging a context manager. #606

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

winterfroststrom
Copy link
Contributor

@winterfroststrom winterfroststrom commented Jul 29, 2019

This change is Reviewable

Copy link
Collaborator

@xpconanfan xpconanfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @winterfroststrom and @xpconanfan)


mobly/test_runner.py, line 222 at r1 (raw file):

    @contextlib.contextmanager
    def log(self):

log is commonly used for the actual function call that generates a log line.
how about a different name? like mobly_logger or something?

Copy link
Contributor Author

@winterfroststrom winterfroststrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @winterfroststrom and @xpconanfan)


mobly/test_runner.py, line 222 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…

log is commonly used for the actual function call that generates a log line.
how about a different name? like mobly_logger or something?

changed

Copy link
Collaborator

@xpconanfan xpconanfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @winterfroststrom)

@winterfroststrom winterfroststrom merged commit 1ff98f1 into google:master Jul 31, 2019
@winterfroststrom winterfroststrom deleted the context_logger branch September 13, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants