Garbee/feature/toolbar #5412
Open
Garbee/feature/toolbar #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may end up reimplementing cards, but merging this small fix now gives us a nice baseline anyway. Fixes #1396.
Fix card text width. Potentially breaking change for styling.
Add contributor note about the branch split.
Snackbar alignment fixed
Using current stable version for evergreen browsers, IE11 for compatibility, and Safari/iOS Safari version 8.
Updating autoprefixer config and README for V2.0 supported browsers.
Also adds missing elevations.
Removing requestAnimationFrame polyfill now we've dropped IE9.
Making shadow declarations consistent between elevations 0 and 24.
Updates the test conditions so that all of them are checking for Object property using "'propertyName' in Object" pattern. This makes it easier to interpret the individual conditions and what they are checking for, and removes the need for creating an element on the document object simply for testing purposes. Also makes it very clear what the current "cutting-the-mustard" requirements are, eg which properties on which objects need to be present, thus making it easier to unit test and more clear to clients that fail test what is needed to meet minimum requirements.
Update Cutting-the-mustard test
Updating list readme to use correct classes for two and three line variants.
Fix documentation for multiline list item classes
This PR replaces our color variables to use actual colors rather than strings. It also updates the template generation and customizer to use '#name' style placeholders instead of '$name', so that CSSO doesn't complain about the syntax. This PR may later be invalidated if we decide to move away from SASS, but for now it provides a good baseline for current development.
So it can be called throught MaterialTextfield instead of retrieving the inner input element
Use actual colors in SASS variables. Rework of #1542.
fix(infrastructure): ignore recursive node_modules
* Auto-installs a `commit-msg` hook when `npm (i|install)` is run. * Ensures that the commit message is formatted properly according to angular's conventions. Note that as outlined in the `helpMsg` key, this can always be disabled by passing the `--no-verify` option to `git-commit`. Part of #4464
chore(infrastructure): Add validate-commit-msg hook
* Add .travis.yml file to the repo, enabling TravisCI to run against PRs for master and branches of. * Set up Sauce Labs running on the last two versions of every major browser (excluding Android 4 and Opera). Android 4 is quite old, and Opera is very similar to Chrome as it uses blink/chromium under the hood. * Work around [SauceLabs PR restriction](https://docs.travis-ci.com/user/pull-requests#Pull-Requests-and-Security-Restrictions) by falling back to running tests on Chrome and FF latest only when PR comes from a repo fork. SL Tests are then run when the PR gets merged to master. * Fix false negative in IE11 for mdl-auto-init test. Part of #4464 [#126818909]
chore(infrastructure): Set up continuous integration [#126818909]
- Update README, CONTRIBUTING, and docs/DEVELOPER with relevant v2 info - Add support for commitizen for easy commit messages Resolves #4464 [Delivers #126818909]
chore(infrastructure): Have stylelint ignore the build directory.
Adds a license header to every source file, minus templates. Fixes #4583. [Finishes #126890507]
Needed to support running fallback CI tests against chrome
REM units align with what the specification uses as `sp` closest. So we uses rem in order to adjust to client font size changes.
SequentialAnimation class will be removed during migration to new adapter pattern.
test(ripple): add ripple tests
- Change `mdl-base-component` -> `mdl-base` - Add description and correct license to `mdl-base` - Implement base foundation and component classes - Deprecate MDLBaseAdapter; remove from index exports - Update all build and dependency targets - (extra) Fix false positive in mdl-auto-init test - (extra) Update quotes eslint rule to avoid escaping - (extra) Fix failing ripple tests - (extra) Allow TravisCI to run all PRs via saucelabs Resolves #4579 [Delivers #126819203]
Implements initial variables, mixins and CSS classes for typography. Resolves #4542. [Delivers #126819303]
feat(typography): Implement initial typography.
…4612) Browsers which are not currently working include Safari (both desktop and iOS) and Edge. Support ticket with Sauce Labs is open to try and resolve. Until that time, disabling to prevent false negatives. Also limits concurrency to 4 VMs at once, which prevents us from going over the 5 concurrent VM limit for the Open Sauce plan.
Some parts of the spec are defined as point units specifically, which we translate to pixels. Until we have further guidance, these places should be obeyed as pixel.
We target under fieldset which throws off the BEM linter a bit. This allows us to target fieldset disabled states without linting errors.
Use the postcss bem linter to lint the button syntax. Ignoring the double-class selectors we use to simplify the codes usage.
Let Tooltips have control over the after psuedo element so they will inter-operate with buttons.
Use node packages to handle making directories, deleting files, and setting environment variables so the npm scripts will operate correctly on Windows.
* feat(animation): Clean up mdl-animation, add README * feat(checkbox): Add initial checkbox implementation This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
Implements initial cards, sans expansion and side-placed media.
feat(card): Initial implementation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please fixed the navbar