-
Notifications
You must be signed in to change notification settings - Fork 5k
Card Supporting text has the wrong width #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Garbee I'm using mdl in one of my projects and have fixed this and tested it on Desktop as well as mobile. Since this is my first commit, if you can please look at it once on my fork, and see if it's ok, I will submit a proper pull request. |
The change is right, but I currently consider changing the width a BC break since the 90% could be expected by developers in their projects (especially if they have automated visual test suites.) Right now we aren't focusing on V2 things since we still have V1.1 to get out plus patches to that. cc @sgomes @addyosmani @surma - Any thoughts on whether we should consider width changing a BC break in this case? If we want to go ahead and do it in 1.1 then we can accept a PR for this in master now. |
i too came across this, and unfortunatley just removing the 90% width isnt a full fix. The |
We may end up reimplementing cards, but merging this small fix now gives us a nice baseline anyway. Fixes #1396.
Fixed in |
The card supporting text has a width of 90%. But it should take the full width.


spec:
The text was updated successfully, but these errors were encountered: