Skip to content

Card Supporting text has the wrong width #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tleunen opened this issue Aug 14, 2015 · 5 comments
Closed

Card Supporting text has the wrong width #1396

tleunen opened this issue Aug 14, 2015 · 5 comments
Milestone

Comments

@tleunen
Copy link
Contributor

tleunen commented Aug 14, 2015

The card supporting text has a width of 90%. But it should take the full width.
screen shot 2015-08-14 at 7 28 29 pm
spec:
screen shot 2015-08-14 at 7 29 59 pm

@Garbee Garbee added this to the V2 milestone Sep 2, 2015
@vinay20045
Copy link

@Garbee I'm using mdl in one of my projects and have fixed this and tested it on Desktop as well as mobile. Since this is my first commit, if you can please look at it once on my fork, and see if it's ok, I will submit a proper pull request.

@Garbee
Copy link
Collaborator

Garbee commented Oct 17, 2015

The change is right, but I currently consider changing the width a BC break since the 90% could be expected by developers in their projects (especially if they have automated visual test suites.) Right now we aren't focusing on V2 things since we still have V1.1 to get out plus patches to that.

cc @sgomes @addyosmani @surma - Any thoughts on whether we should consider width changing a BC break in this case? If we want to go ahead and do it in 1.1 then we can accept a PR for this in master now.

@sgomes
Copy link
Contributor

sgomes commented Oct 19, 2015

@Garbee: Probably best to play it safe and keep it out of 1.1, since it may break styling for some people. Let's leave the issue open to keep track of this, though.

Thanks for the find, @tleunen!

@leemason
Copy link

leemason commented Feb 9, 2016

i too came across this, and unfortunatley just removing the 90% width isnt a full fix. The box-sizing property of the div also needs to be set to border-box.

sgomes pushed a commit that referenced this issue Feb 12, 2016
We may end up reimplementing cards, but merging this small fix
now gives us a nice baseline anyway.

Fixes #1396.
@sgomes
Copy link
Contributor

sgomes commented Feb 12, 2016

Fixed in master. Since this is a potentially breaking change, it won't appear in the 1.1 branch, but 2.0 will have the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants