Skip to content

Allow unknown fields in corpus parser #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitalybuka merged 3 commits into from
Apr 23, 2020
Merged

Allow unknown fields in corpus parser #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9732035
Allow unknown fields in corpus parser
nareddyt Apr 17, 2020
40ccfdc
Add test
nareddyt Apr 17, 2020
7438809
Review comments
nareddyt Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/mutator_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,14 @@ const char kOptionalInDeepAnyFields[] = R"(
}
)";

const char kUnknownFieldInput[] = R"(
optional_bool: true
unknown_field: "test unknown field"
)";

const char kUnknownFieldExpected[] = R"(optional_bool: true
Copy link
Contributor Author

@nareddyt nareddyt Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline matters here FYI (there shouldn't be one)

)";

class TestMutator : public Mutator {
public:
explicit TestMutator(bool keep_initialized,
Expand Down Expand Up @@ -668,6 +676,12 @@ TYPED_TEST(MutatorTypedTest, Serialization) {
}
}

TYPED_TEST(MutatorTypedTest, UnknownFieldTextFormat) {
typename TestFixture::Message parsed;
EXPECT_TRUE(ParseTextMessage(kUnknownFieldInput, &parsed));
EXPECT_EQ(SaveMessageAsText(parsed), kUnknownFieldExpected);
}

TYPED_TEST(MutatorTypedTest, DeepRecursion) {
typename TestFixture::Message message;
typename TestFixture::Message* last = &message;
Expand Down
1 change: 1 addition & 0 deletions src/text_format.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ bool ParseTextMessage(const std::string& data, protobuf::Message* output) {
TextFormat::Parser parser;
parser.SetRecursionLimit(100);
parser.AllowPartialMessage(true);
parser.AllowUnknownField(true);
if (!parser.ParseFromString(data, output)) {
output->Clear();
return false;
Expand Down