Allow unknown fields in corpus parser#170
Merged
vitalybuka merged 3 commits intogoogle:masterfrom Apr 23, 2020
Merged
Conversation
As discussed in envoyproxy/envoy#10796, this will allow breaking wire-compatibility changes in the input proto. The pre-existing corpus will still function, but old fields will be ignored. Risk: Typos in the text proto will cause the fuzzer to run on an incomplete proto. Previously, this would log an error message and skip fuzzing with that test case.
Contributor
Author
vitalybuka
reviewed
Apr 17, 2020
vitalybuka
reviewed
Apr 17, 2020
Contributor
Author
|
You may want to check this out and run the tests to verify my PR. I keep getting a test failure on my workstation: Edit: Oh, it happens on master too. Nevermind |
vitalybuka
approved these changes
Apr 18, 2020
Signed-off-by: Teju Nareddy <nareddyt@google.com>
nareddyt
commented
Apr 20, 2020
| unknown_field: "test unknown field" | ||
| )"; | ||
|
|
||
| const char kUnknownFieldExpected[] = R"(optional_bool: true |
Contributor
Author
There was a problem hiding this comment.
Newline matters here FYI (there shouldn't be one)
Collaborator
|
Looks like we need to rollback this and fix issue in proto Now it triggers stack overflows like |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in envoyproxy/envoy#10796, this will allow breaking wire-compatibility changes in the input proto. The pre-existing corpus will still function, but old fields will be ignored.
Risk: Typos in the text proto will cause the fuzzer to run on an incomplete proto. Previously, this would log an error message and skip fuzzing with that test case.
Testing: I'm not sure how to add it to
mutator_test.cc. I manually tested that unknown text format files will be parsed withoutParseTextMessagereturning false.