Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Adding UTs to new receive adapter #1345

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

nachocano
Copy link
Member

Fixes #1333

Proposed Changes

  • 🧽 Adding UTs to receive adapter.

Release Note

NONE

Docs

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 25, 2020
@nachocano
Copy link
Member Author

/assign @yolocs
/assign @Harwayne

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pubsub/adapter/adapter.go 0.0% 66.7% 66.7

@capri-xiyue
Copy link
Contributor

/lgtm

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-wi-tests
3/3

Job pull-google-knative-gcp-wi-tests expended all 3 retries without success.

@nachocano
Copy link
Member Author

/test pull-google-knative-gcp-wi-tests

@knative-prow-robot knative-prow-robot merged commit ecfb095 into google:master Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UTs for newer Receive Adapter
8 participants