Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Add UTs for newer Receive Adapter #1333

Closed
nachocano opened this issue Jun 23, 2020 · 0 comments · Fixed by #1345
Closed

Add UTs for newer Receive Adapter #1333

nachocano opened this issue Jun 23, 2020 · 0 comments · Fixed by #1345
Assignees
@nachocano
Labels
area/sources priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Milestone
v0.16.0-M3

Comments

@nachocano
Copy link
Member

Describe the bug
As part of #1296 we completely change the old receive adapter logic.
Previous UTs were completely coupled with converters and not well structured. We should redo all the UTs once that PR gets merged.

Expected behavior
RA has UTs
@nachocano nachocano added kind/bug Something isn't working area/sources priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 and removed kind/bug Something isn't working labels Jun 23, 2020
@nachocano nachocano added this to the v0.16.0-M3 milestone Jun 23, 2020
@nachocano nachocano self-assigned this Jun 23, 2020
@nachocano nachocano mentioned this issue Jun 24, 2020
Merged
@nachocano nachocano mentioned this issue Jun 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nachocano nachocano

Labels
area/sources priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Projects
None yet
Milestone
v0.16.0-M3
Development

Successfully merging a pull request may close this issue.

Adding UTs to new receive adapter nachocano/knative-gcp
1 participant
@nachocano