changed reconciler, UT and e2e to be v1beta1

[capri-xiyue]

Fixes #1168
Fixes #1211

Proposed Changes

• 🎁 Moving CloudBuildSource to v1beta1.
• 🧽 All reconcilers now reconcile v1beta1 resources.
• 🧽 All UTs and E2E tests use v1beta1 resources

Release Note

Moving CloudBuildSource to v1beta1.

Docs

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [capri-xiyue]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nachocano]

I know is WIP, but do you think is possible to separate the CloudBuildSource move to v1beta1 in another PR? As that one is not high priority, and I think we don't have E2E tests for it yet?

[Harwayne]

It looks like this PR is doing multiple things. I recommend breaking it up:

• Create CloudBuildSource v1beta1 version.
  • v1beta1 - Sources #812 and Sources v1beta1 conversions #827 are how it was done for other sources.
• Switch reconcilers to use the v1beta1 versions.

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-google-knative-gcp-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-integration-tests:

github.com/google/knative-gcp/test/e2e.[build failed]

[knative-test-reporter-robot]

The following jobs failed:

Test name	Triggers	Retries
pull-google-knative-gcp-wi-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-wi-tests:

github.com/google/knative-gcp/test/e2e.[build failed]

[capri-xiyue]

It looks like this PR is doing multiple things. I recommend breaking it up:

• Create CloudBuildSource v1beta1 version.

  • v1beta1 - Sources #812 and Sources v1beta1 conversions #827 are how it was done for other sources.

• Switch reconcilers to use the v1beta1 versions.

I didn't realize I need to create CloudBuildSource v1beta1 version until I ran into build failure.
All sources share the same test helper methods(like pullsubscriptions and topics)
If we don'r push CloudBuildSource to v1beta1, we need to have two versions of test helper methods, one for v1alpha1 and the other for v1beta1.

I will try to see whether it's easy to break it into two PRs

[capri-xiyue]

/retest

[capri-xiyue]

/test pull-google-knative-gcp-build-tests

[capri-xiyue]

/test pull-google-knative-gcp-unit-tests

[capri-xiyue]

/test pull-google-knative-gcp-unit-tests

[capri-xiyue]

All E2E tests related to pubsub channel broke again.
I will try to see if I can reproduce the same failure in local

[nachocano]

Can you update the description and release notes of the PR? We auto-generate the release notes based on that, so it's better to include this...

I'm willing to let this in because we are kind of in a hurry and there are other P1s. I don't see a problem as we are not releasing CloudBuildSource for now.
I think next time we can try and break it down into multiple PRs as Adam mentioned.. I understand that it would have meant more work for the UTs though...

If @Harwayne agrees, I think after the comments are resolved, we can get this in asap...

[nachocano]

@Harwayne shall we change everywhere to?

versions:

• name: v1alpha1
  served: false
  storage: false
• name: v1beta1
  served: true
  storage: true

[capri-xiyue]

I don't think I can change it to things as above.
Otherwise, we can't create v1alpha1 resources anymore
It looks like it should be
versions:

• name: v1alpha1
  served: true
  storage: false
• name: v1beta1
  served: true
  storage: true

[nachocano]

ok, please sync with Adam tomorrow, as he knows better about this... If it passes, I think we can let it in...

[capri-xiyue]

/retest

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/duck/v1beta1/annotations.go	93.2%	77.8%	-15.4
pkg/apis/events/v1alpha1/cloudbuildsource_conversion.go	Do not exist	100.0%
pkg/apis/events/v1beta1/cloudbuildsource_conversion.go	Do not exist	100.0%
pkg/apis/events/v1beta1/cloudbuildsource_defaults.go	Do not exist	100.0%
pkg/apis/events/v1beta1/cloudbuildsource_lifecycle.go	Do not exist	100.0%
pkg/apis/events/v1beta1/cloudbuildsource_types.go	Do not exist	71.4%
pkg/apis/events/v1beta1/cloudbuildsource_validation.go	Do not exist	87.5%
pkg/apis/intevents/v1beta1/topic_lifecycle.go	56.7%	54.8%	-1.8
pkg/reconciler/messaging/channel/channel.go	78.0%	78.7%	0.7

[nachocano]

Thanks @capri-xiyue this huuuugeee change!!!

/lgtm